Add fraction_field_type and define fraction_field method for fields
#2132
+57
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2132 +/- ##
==========================================
- Coverage 87.98% 87.97% -0.01%
==========================================
Files 126 126
Lines 31665 31670 +5
==========================================
+ Hits 27860 27862 +2
- Misses 3805 3808 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Added a breaking label since this needs downstream changes in form of oscar-system/Oscar.jl#5153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relanding PR #2092 (see also #2128 and #2130). Needs oscar-system/Oscar.jl#5153