Feat/stock provider adapter 8#15
Merged
Villarley merged 4 commits intoNeko-Protocol:mainfrom Jan 31, 2026
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Neko Pull Request
Mark with an
xall the checkboxes that apply (like[x])📌 Type of Change
📝 Changes description
The first external stock price provider was implemented for the Neko-Oracle-RWA system. I focused on establishing a solid and scalable foundation, not just the API connection.
Selection of Finnhub: I decided to move forward with Finnhub for this POC due to its low latency for US market data and its clean response structure, ensuring that the oracle receives accurate information with minimal overhead.
Architecture: I separated the StockService from the FinnhubAdapter, making the system vendor-agnostic. For example, if they need to change their API in the future, the core of the ingestor will remain unchanged.
Data Normalization: I implemented a transformation layer that "hardens" the system. The adapter converts the raw response into a standardized object, enforcing numeric types and normalizing tickers to uppercase to prevent inconsistencies in the future database.
Security: All credential management was integrated using environment variables (.env), ensuring that API keys are never leaked into version control.
Monorepo Integration: I synchronized the types in @oracle-stocks/shared to ensure that the data contract is respected by all microservices in the Neko ecosystem.
📸 Evidence (A Loom/Cap video is required as evidence, we WON'T merge if there's no proof)
⏰ Time spent breakdown
Finnhub API Research: 20 min
Adapter and Service Implementation: 45 min
Monorepo Integration and Debugging: 30 min
Total: ~1 hr 35 min
🌌 Comments