Skip to content

Mark some unused variables #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
out-of-phaze wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Mark some unused variables #5334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/_onclick/hud/screen/screen_intent.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
requires_ui_style = FALSE
apply_screen_overlay = FALSE
var/intent_width = 16
var/intent_height = 16
var/intent_height = 16 // currently unused
Copy link
Copy Markdown
Contributor

@MistakeNot4892 MistakeNot4892 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed, it was for when intents were offset vertically but they are only ever offset horizontally now.

Copy link
Copy Markdown
Member Author

@out-of-phaze out-of-phaze Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason i was under the impression that this was for, like, robot/silicon UIs or something where they were laid out differently

Copy link
Copy Markdown
Contributor

@MistakeNot4892 MistakeNot4892 May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to my knowledge.

var/list/intent_selectors

/obj/screen/intent/Initialize(mapload, mob/_owner, decl/ui_style/ui_style, ui_color, ui_alpha, ui_cat)
Expand Down
2 changes: 1 addition & 1 deletion code/modules/backgrounds/citizenship/_citizenship.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/decl/background_detail/citizenship
abstract_type = /decl/background_detail/citizenship
category = /decl/background_category/citizenship
var/ruling_body = "Other Faction"
var/ruling_body = "Other Faction" // currently unused? todo: display this or remove it? nothing seems to actually set it...
Copy link
Copy Markdown
Contributor

@MistakeNot4892 MistakeNot4892 Apr 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might have been a partial port from the Polaris sync, it should be in the info box on chargen. I can do this if I remember.

Copy link
Copy Markdown
Member Author

@out-of-phaze out-of-phaze May 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted, think that's the only one still standing then? EDIT: that and tallness

var/capital
var/size_heading = "Systems"
var/size_value
Expand Down
2 changes: 1 addition & 1 deletion code/modules/maps/template_types/random_exoplanet/planetoid_data.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
///Preferred height for all the planet z-levels. Null means it's up to each z-levels. Not reliable for telling the height of the levels under this planet.
var/height
///Preferred amount of vertically connected z-levels for this planets. Null means it's up to each z-levels.
var/tallness = 1
var/tallness = 1 // unused, seems to be made redundant by /datum/map_template/planetoid/tallness
///Topmost level data datum id of the root z stack (ID only, because this datum has an uncontrolled lifetime, and we don't want dangling refs)
var/topmost_level_id
///Level data id for the level that's considered to be the planet's surface. In other words, the topmost firm ground level of the root z stack.
Expand Down
6 changes: 3 additions & 3 deletions code/modules/projectiles/projectile.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@
var/fire_sound
var/fire_sound_vol = 50
var/fire_sound_vol_silenced = 10
var/miss_sounds
var/ricochet_sounds
var/list/impact_sounds //for different categories, IMPACT_MEAT etc
var/miss_sounds // CURRENTLY UNUSED
var/ricochet_sounds // CURRENTLY UNUSED
var/list/impact_sounds //for different categories, IMPACT_MEAT etc. CURRENTLY UNUSED
Copy link
Copy Markdown
Contributor

@MistakeNot4892 MistakeNot4892 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird, these should have been replaced by static getters I believe.

Copy link
Copy Markdown
Contributor

@MistakeNot4892 MistakeNot4892 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My dev was out of date, these can all be removed in lieu of get_ricochet_sounds() and co.

var/shrapnel_type = /obj/item/shard/shrapnel

var/vacuum_traversal = 1 //Determines if the projectile can exist in vacuum, if false, the projectile will be deleted if it enters vacuum.
Expand Down
2 changes: 1 addition & 1 deletion code/modules/salvage/structure.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
tool_interaction_flags = TOOL_INTERACTION_DECONSTRUCT
material = /decl/material/solid/metal/steel
var/frame_type = /obj/machinery/constructable_frame/machine_frame
var/work_skill = SKILL_CONSTRUCTION
var/work_skill = SKILL_CONSTRUCTION // currently unused
Copy link
Copy Markdown
Contributor

@MistakeNot4892 MistakeNot4892 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded since I made this use structure dismantling for dropping products, can be removed.


/obj/structure/salvage/proc/get_salvageable_components()
return
Expand Down
Loading