Skip to content

fix: remove lock_time validation for BTC transactions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MagicGordon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove lock_time validation for BTC transactions #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion contracts/satoshi-bridge/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "satoshi-bridge"
version = "0.5.0"
version = "0.5.1"
edition.workspace = true
publish.workspace = true
repository.workspace = true
Expand Down
3 changes: 3 additions & 0 deletions contracts/satoshi-bridge/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Release Notes

### Version 0.5.1
1. remove lock_time validation for BTC transactions

### Version 0.5.0
1. fix audit recommendation.

Expand Down
4 changes: 0 additions & 4 deletions contracts/satoshi-bridge/src/api/bridge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ impl Contract {
let transaction = bytes_to_btc_transaction(&tx_bytes);
let deposit_amount = transaction.output[vout].value.to_sat() as u128;
require!(deposit_amount > 0, "Invalid deposit_amount");
require!(
transaction.lock_time == LockTime::ZERO,
"Tx with a non-zero lock_time are not supported."
);
let deposit_address = self.generate_btc_p2wpkh_address(&path);
let deposit_address_script_pubkey = deposit_address.script_pubkey();
require!(
Expand Down