Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/js-lib/src/http/fetcher.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,27 @@ test('retryAfter date', async () => {
expect(r).toBe('ok')
})

test('retryAfter cloudflare body', async () => {
vi.useFakeTimers()
const fetcher = getFetcher({
debug: true,
})

// Cloudflare returns retry-after:0 but encodes the real wait in the JSON body as retry_after
const badResponse = (): Response =>
Response.json({ retry_after: 2 }, { status: 429, headers: { 'retry-after': '0' } })

vi.spyOn(Fetcher, 'callNativeFetch')
.mockResolvedValueOnce(badResponse())
.mockResolvedValueOnce(badResponse())
.mockResolvedValueOnce(new Response('ok'))

const promise = fetcher.getText('')
await vi.runAllTimersAsync()
const r = await promise
expect(r).toBe('ok')
})

test('tryFetch', async () => {
vi.spyOn(Fetcher, 'callNativeFetch').mockResolvedValue(
new Response('bad', {
Expand Down
9 changes: 9 additions & 0 deletions packages/js-lib/src/http/fetcher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,15 @@ export class Fetcher {
this.cfg.logger.warn('retry-after could not be parsed')
}
}

// Cloudflare returns retry-after:0 but includes the real delay in the body as retry_after
if (!(timeout > 0) && res.body && typeof res.body === 'object') {
const bodyRetryAfter = (res.body as any).retry_after
if (typeof bodyRetryAfter === 'number' && bodyRetryAfter > 0) {
timeout = bodyRetryAfter * 1000
this.cfg.logger.log(`retry-after (from body): ${bodyRetryAfter}`)
}
}
}

if (!timeout) {
Expand Down