Skip to content

Fix PHP 8.4 builds on Windows #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 26, 2024
Merged

Fix PHP 8.4 builds on Windows #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6158304
fix: 7za | tar not working on bash shell
SRWieZ Dec 17, 2024
483f919
fix: php-bin directory does not exist at first build
SRWieZ Dec 17, 2024
9445fb7
fix: update extension list with essential dependencies
SRWieZ Dec 17, 2024
13253b7
fix: temp fix to windows build
SRWieZ Dec 24, 2024
ac68852
Revert "fix: temp fix to windows build"
SRWieZ Dec 24, 2024
12249ad
fix: patched a patch. Is it stupid if it works?
SRWieZ Dec 25, 2024
908aab2
fix: patched a patch. Is it stupid if it works?
SRWieZ Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/build-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ jobs:
git clone https://github.com/crazywhalecc/static-php-cli.git
cd static-php-cli
git checkout main
cd ../php-bin
cd ../
[ ! -d php-bin ] && mkdir -p php-bin
cd php-bin

- shell: bash
run: |
Expand Down Expand Up @@ -118,8 +120,22 @@ jobs:
./bin/spc download --with-php=${{ matrix.version }} --for-extensions "${{ env.PHP_EXTENSIONS }}" --prefer-pre-built
cd ../php-bin

- name: Build PHP
- name: Patch for windows 8.4 builds
shell: bash
run: |
cd ../static-php-cli
cp downloads/micro/patches/cli_static.patch downloads/micro/patches/cli_static_80.patch
cp downloads/micro/patches/cli_static.patch downloads/micro/patches/cli_static_81.patch
cp downloads/micro/patches/cli_static.patch downloads/micro/patches/cli_static_82.patch
cp downloads/micro/patches/cli_static.patch downloads/micro/patches/cli_static_83.patch
cp downloads/micro/patches/cli_static.patch downloads/micro/patches/cli_static_84.patch
sed -i '18d' downloads/micro/patches/cli_static_84.patch
sed -i 's/+1160,11/+1160,10/' downloads/micro/patches/cli_static_84.patch
rm -f downloads/micro/patches/cli_static.patch
cat downloads/micro/patches/cli_static_84.patch
cd ../php-bin

- name: Build PHP
run: |
cd ../static-php-cli
./bin/spc build --build-cli "${{ env.PHP_EXTENSIONS }}"
Expand Down
2 changes: 1 addition & 1 deletion php-extensions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
bcmath,ctype,curl,dom,fileinfo,filter,gd,mbstring,opcache,openssl,pdo,pdo_sqlite,phar,session,simplexml,sockets,sqlite3,tokenizer,xml,zip,zlib
bcmath,bz2,ctype,curl,dom,fileinfo,filter,gd,iconv,mbstring,opcache,openssl,pdo,pdo_sqlite,phar,session,simplexml,sockets,sqlite3,tokenizer,xml,zip,zlib