Fix off by one register init check in pcode byte state#9239
Open
EmirX3D wants to merge 1 commit into
Open
Conversation
EmirX3D
force-pushed
the
fix-pcode-register-values-defined-ranges
branch
from
31d875b to
81f3c88
Compare
nsadeveloper789
added
Status: Prioritize
Contributor
|
I'm prepared to accept this; however, there is a discrepancy between your username on github and that given in your commit author. Please correct it if you'd like to retain credit for the changes. |
nsadeveloper789
added
Status: Internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix BytesPcodeExecutorStateSpace.getRegisterValues() so register ranges are checked with an inclusive end offset, allowing fully initialized registers such as EDX/EAX/r0 to be returned immediately without requiring the following register byte to be initialized, and add a regression test for the exact initialized register boundary case.
Closes #9238