Remove dead workflows_with_failures branch in transport_update_workflow#303
Merged
daniel-thom merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
After #300 made is_archived read-only on update_workflow, this branch can never fire — body.is_archived is documented and emitted as readOnly, so any client value is silently ignored, and update_workflow no longer mutates the column. The cleanup is now reachable via transport_archive_workflow, which is the only path that can set is_archived = true. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #300 made is_archived read-only on update_workflow, this branch can never fire — body.is_archived is documented and emitted as readOnly, so any client value is silently ignored, and update_workflow no longer mutates the column. The cleanup is now reachable via transport_archive_workflow, which is the only path that can set is_archived = true.