Merged
Conversation
2377336757 Merge pull request #2183 from NatLabRockies/buildreshpxml_attach_adiabatic_floors 87217f46b7 Fix adiabatic surfaces not being attached to attics/foundations in the BuildResidentialHPXML measure. Also, for files that we manually modify in tasks.rb, fixes some of the attic/foundation attached surfaces (and adds error-checking to ensure we update them for future files). 17b194f191 Merge branch 'master' of https://github.com/NatLabRockies/OpenStudio-HPXML into buildreshpxml_attach_adiabatic_floors ddd954f4f1 Merge pull request #2181 from NatLabRockies/nlr_links 172d90dc4f Update links to websites/docs. 3a766145c3 Clarify "Load: Heating: Heat Pump Backup" output. [ci skip] 7671191583 Merge pull request #2176 from NatLabRockies/schematron_messages 4085188c7e BuildResidentialHPXML measure: Attach adiabatic floors to the AboveApartment foundation element and the BelowApartment attic element. git-subtree-dir: hpxml-measures git-subtree-split: 2377336757fc60b10c36f51149477421a5a5252b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[description here]
Checklist
Not all may apply:
openstudio tasks.rb update_hpxmls)rulesets\testsand/orworkflow/tests/*_test.rb)openstudio tasks.rb update_measureshas been run