fix: correct natural ventilation area unit conversion#220
Open
rcbevans wants to merge 1 commit intoNatLabRockies:devfrom
Open
fix: correct natural ventilation area unit conversion#220rcbevans wants to merge 1 commit intoNatLabRockies:devfrom
rcbevans wants to merge 1 commit intoNatLabRockies:devfrom
Conversation
Author
|
This PR will close #219 when merged. |
Collaborator
|
This looks like a good catch! I need to take a little time tomorrow to confirm, but we do appreciate you catching this and putting in a PR! For what it's worth: natural ventilation really only comes into play if you can basically get some free cooling from opening the windows, and in those cases it's a pretty large area that you can get airflow through, even without messing up the units. My guess is this has pretty small impact on the results and that's how it hasn't been caught until now, but I'll confirm that too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #219