Standardize Feedstock Outputs (follow-on to 463) by elenya-grant · Pull Request #523 · NatLabRockies/H2Integrate

elenya-grant · 2026-02-11T16:57:21Z

Standardize Feedstock Outputs (follow-on to 463)

Updated feedstock component to have standard outputs (like those output from the PerformanceModelBaseClass). Feedstock model now outputs capacity_factor, annual_commodity_consumed, and total_commodity_consumed. Note that these are output from the FeedstockCostModel, which is due to the special handling of feedstock components.

This PR was re-opened because it seemed relevant for PR #605 so that non-electricity commodities could also be used with the updated dispatch method that is introduced in PR #605.

This PR is ready for high-level feedback, the questions for reviewers are noted in Section 2!

Section 1: Type of Contribution

Section 2: Draft PR Checklist

Open draft PR
Describe the feature that will be added
Fill out TODO list steps
Describe requested feedback from reviewers on draft PR
[-] Complete Section 7: New Model Checklist (if applicable)

TODO:

depends on reviewer feedback.
update feedstocks.md
add test of feedstock component integrated with finance model (by adding it to an example)

Type of Reviewer Feedback Requested (on Draft PR)

Structural feedback:

Is there any reason why the feedstock standard outputs be following the "produced" naming instead of "consumed"? I think that it makes sense for feedstock standard outputs to be "consumed".

Implementation feedback:

Other feedback:

Section 3: General PR Checklist

PR description thoroughly describes the new feature, bug fix, etc.
Added tests for new functionality or bug fixes
Tests pass (If not, and this is expected, please elaborate in the Section 6: Test Results)
Documentation
- Docstrings are up-to-date
- Related docs/ files are up-to-date, or added when necessary
- Documentation has been rebuilt successfully
- Examples have been updated (if applicable)
CHANGELOG.md has been updated to describe the changes made in this PR

Section 3: Related Issues

Made Issue #659 when creating this PR, this issue is not resolved by this PR

Resolves part of Issue #485 about updates feedstock to have standardized performance

Section 4: Impacted Areas of the Software

Section 4.1: New Files

None

Section 4.2: Modified Files

h2integrate/core/feedstocks.py:
- FeedstockCostModel:
  - added input of commodity_out, which is used as the denominator in the capacity factor calculation
  - added outputs of capacity_factor, annual_commodity_consumed, and total_commodity_consumed
examples/test/test_all_examples.py::test_natural_gas_example added subtest for feedstock capacity factor
h2integrate/core/test/test_feedstocks.py: added new test test_feedstock_standard_outputs
h2integrate/core/h2integrate_model.py
- H2IntegrateModel.connect_technologies(): added connection to connect commodity_out output of the feedstock performance model to the input commodity_out of the feedstock cost model (this was needed because the FeedstockCostModel and FeedstockPerformanceModel are not part of the same sub-system (they don't have shared inputs/outputs - they're connected using connections, not promoted inputs/outputs))
examples/16_natural_gas/tech_config.yaml: added some comments for natural gas feedstock
h2integrate/tools/profast_tools.py:
- make_price_breakdown(): updated so it can handle cases with a zero total capex.
examples/12_ammonia_synloop/
- tech_config.yaml: updated n2_feedstock price to be $5.0/t (instead of 0) or to prevent errors when trying to run profast with zero costs
- plant_config.yaml: added n2 finance subgroup for integration testing purposes. Removed n2_feedstock from the nh3 technology group so that LCOA doesn't change in tests (before the n2_feedstock had zero cost, but the update to the n2_feedstock price would give a larger LCOA if included). Could instead update the test value if desired.
pytest examples/test/test_all_examples.py::test_ammonia_synloop_example: added subtest for LCON

Section 5: Additional Supporting Information

Section 6: Test Results, if applicable

N/A

…_out between performance and cost model

…T into feedstock_updates

…dates

…T into feedstock_updates

johnjasa · 2026-02-13T22:40:18Z

Is there any reason why the feedstock standard outputs be following the "produced" naming instead of "consumed"? I think that it makes sense for feedstock standard outputs to be "consumed"

Stick with consumed imo. That's more clear given how we're handling feedstock quantities.

johnjasa

Thanks for this, Elenya! I like the thought you put into the feedstocks setup and how it could be more standard to match other components. I also appreciate you fixing the NG units to be consistently correct.

My blocking request is for you to update feedstocks.md as well. Could you please change that doc so it matches what you've done here, then also add a few words to explain the CF calculation and anything else you introduce here?

johnjasa · 2026-02-16T23:13:57Z

+            f"total_{self.commodity}_consumed"
+        ] * (1 / self.fraction_of_year_simulated)
+
+        outputs[f"rated_{self.commodity}_production"] = inputs[f"{self.commodity}_out"].max()


I know I brought this up on a call, but I forget where we landed. Will this assumption (that the rated production is the max of the commodity stream) be limiting in any way? Would this go against users' intuition at some point?

I don't think so - the inputs[f"commodity_out"] is the output from the performance model, which outputs the commodity_out as an array of all the same values. Aka - the max should equal the mean which should equal the "commodity_capacity" input to the performance model.

johnjasa · 2026-02-16T23:14:39Z

+        # Calculate performance based on consumption
+


Suggest removing comment as it isn't necessarily helpful

kbrunik

I agree with @johnjasa, it would be good to explain the CF calculation, and the other output performance values (and maybe that it's called consumed instead of produced) in the feedstocks docpage. Otherwise I think this looks really good! Thanks for doing this update, it really helps add continuity throughout the models.

Would you also be able to update the changelog?

…T into feedstock_updates

elenya-grant · 2026-04-09T20:29:35Z

@kbrunik - I updated the doc page but would love your feedback on it! I also updated the changeling and addressed your other comments!

kbrunik

Looks great to me! Thanks for adding an explanation about the outputs :)

johnjasa

Nice, I love this generalization and improvement to the feedstock handling! I think especially as we get to more complex multi-commodity systems, this will become even more important. Thank you for also updating example 12 so that there's an LCON computed; it made the capabilities afforded through this PR very clear!

@jaredthomas68

* Remove old iron models (#601) * removed temporary iron and steel models * supported models * update example 28 with updated models * remove outdated files * consolidate iron examples * fix all the stuff I broke * update docs and changelog * update example name and add model names to docs * update changelog --------- Co-authored-by: elenya-grant <116225007+elenya-grant@users.noreply.github.com> * update SMR energy conversion ratio and tests (#606) * update SMR energy conversion ratio and tests * update changelog * docs * minor updates to inline comments * update usage based on hydrogen production --------- Co-authored-by: Rob Hammond <13874373+RHammond2@users.noreply.github.com> Co-authored-by: elenya-grant <116225007+elenya-grant@users.noreply.github.com> Co-authored-by: John Jasa <john.jasa@nrel.gov> Co-authored-by: genevievestarke <103534902+genevievestarke@users.noreply.github.com> Co-authored-by: Jared Thomas <jaredthomas68@gmail.com> Co-authored-by: bayc <christopher.j.bay@gmail.com> Co-authored-by: John Jasa <johnjasa11@gmail.com> Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> Co-authored-by: Jonathan Martin <94018654+jmartin4u@users.noreply.github.com> Co-authored-by: jmartin4 <jonathan.martin@nrel.gov> Co-authored-by: Jonathan Martin <94018654+jmartin4nrel@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Chris Bay <12664940+bayc@users.noreply.github.com> * Break out Pyomo controller simulation code (#587) * Breakout simulation code * Remove duplicate code * Fix testing * Update doc strings and docs * added docstring for heuristic controller config * fixed issue that I made with the HeuristicLoadFollowingControllerConfig * Update docs/control/pyomo_controllers.md Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * Make initialize_parameters() functions the same for both controllers * Apply suggestion from @jaredthomas68 Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * Fix doc string format * Update h2integrate/control/control_strategies/heuristic_pyomo_controller.py Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * Update h2integrate/control/control_strategies/heuristic_pyomo_controller.py Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> * Fix ruff formatting --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> Co-authored-by: elenya-grant <116225007+elenya-grant@users.noreply.github.com> Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> * Bugfix in Charge/Discharge efficiency handling in `StoragePerformanceModel` (#600) * fixed how charge and discharge rates are applied in generic_storage_pyo model --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> * Tests for non-one battery efficiencies (#610) * add unit tests for openloop storage controller with non-one efficiencies * rearrange usage of pytest.approx so the target comes second and uses approx * update changelog: * Sync Storage Autosizing Model and Pass-Through controller to Align with Pyomo Controllers (#608) * updated the storage autosizing and pass through controller for new control and performance model structure * added subtest for integration with pass through controller * updated to use commodity_set_point instead of input-demand * made set_demand_as_avg_commodity_in a required input parameter * moved passthrough controller to storage subfolder * Added minor changes that got missed in PR 600 --------- Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> * Sync Demand Open Loop Controller and Simple Generic Storage to Align with Pyomo Controllers (#612) * updated simple_generic_storage to simulate storage performance * updated demand openloop controller so discharge setpoint is correct * PySAM Marine Models (#607) * tidal resource model and performance model * add performance values for testing * test power curve scaling * marine cost model * tidal example * integration test * documentation * update docs * small changes * update for failing tests * fix equation rendering * fix segmentation fault * add test for using default pysam config * address reviewer feedback * fix wind pysam * attempt to modify file path handling for resource data * fix path stuff * Sync PySAM Battery and Generic Storage Pyomo Performance models with open-loop controllers (#613) * refactored pysam battery and storage performance models to be compatible with updated open-loop controllers * updated generic storage pyo to use pass through controller * renamed PassThroughOpenLoopController to SimpleStorageOpenLoopController * removed simple_generic_storage * renamed xx_charge_fraction to xx_soc_fraction --------- Co-authored-by: Genevieve Starke <genevieve.starke@nrel.gov> * minor error msg and doc corrections (#618) * CO2 Model Fixes (#617) * units and connecting variables * fix doc page * catch if annual_input_energy is 0 * remove base class * fix oae test * failing doc test * fix value call * final touchs * Bugfix: Update storage models so can use different control types per storage type (#615) * updated logic in pysam batery and generic storage to handle multiple storage types * added tests and bugfix in heuristic with setting efficiencies --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> * Baseclass for Openloop Storage Control Strategies (#619) * added openloop control storage baseclass * Enable use of Pyomo Controllers in the Storage Autosizing Model (#621) * updated autosizing storage model to be compatible with pyomo controllers * renamed fixures in heuristic controller tests * aggregated heuristic controller tests into one file * added simple test for storage autosizing and heuristic * renamed fixtures in optimized controller tests * aggregated optimized control tests into one file * updated test for heuristic controller with autosizing * updated so simple storage autosizing can run with optimal pyomo control * Generic cost model for converters (#622) * added generic cost model * added tests and updated model * updated example 3 to use new converter model and added to supported models * updated docstrings and input descriptions * updated changelog * added to model overview * Clarified error message --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> * Introducing multivariable commodity streams (#480) * Working out first steps of multivariable streams * Adding to multivariable streams work * expanding multivariable stream definition * Building out more of the gas combiner * Improving example for multivariable streams * Updating examples and merging * Apply suggestions from code review Co-authored-by: genevievestarke <103534902+genevievestarke@users.noreply.github.com> * Many updates based on PR feedback * Updated to mass fractions for multicommodity stream * renamed a few multicommodity variable names * Added helper functions for multivariable stream definitions * Updated names throughout for multivariable streams * Updated docs for multivariable streams * Added commodity stream tests * Addressing PR feedback * Updates based on PR feedback * Updates based on PR feedback --------- Co-authored-by: genevievestarke <103534902+genevievestarke@users.noreply.github.com> Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> * Removed some shape_by_conn calls due to OM issues (#632) * Removed some shape_by_conn calls due to OM issues * Moved last calls of copy_shape * Fixing test_pipe fail --------- Co-authored-by: jmartin4 <jonathan.martin@nrel.gov> * Move xdsm call in H2IntegrateModel to its own method (#629) * move xdsm creation in H2IModel to a method so user has to call it if desired instead of having it be automatic * update changelog and docs and adjust create_xdsm logic to reflect that it is an optional call * update docs * update docs * update docs for visualization * change xdsm code cell to not execute on build * switch pdf for png * minor comments update in code example * remove xdsm call * Updated XDSM explanation link --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> * Handling Leap Years in OpenMeteo Resource Data (#633) * updated openmeteo resource models to handle leap day * added resource files for leap year * added tests for leap year resource data * added integration w pvwatts test for leap year * Methodized leap day handling for base class for future resource handling --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> * Baseclass for Storage Performance Models (#624) * added draft storage model baseclass * updated draft storage baseclass * added docstring to run_storage method * minor updates to comments in storage_model_baseclass * updated storage performance model to inherit baseclass * fixed storage performance model and storage baseclass * updated storage autosizing model * updated pysam battery to use baseclass and removed battery_baseclass * removed commented out code and simplified some docstrings * removed unnecessary docstrings * updated changelog * PR review: minor personal preferences * updated inline comment --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> * Modified the calc tilt angle function for pysam solar (#646) * Oxygen output from PEM electrolyzer (#642) * added oxygen output from electrolyzer * updated example 14 to calc LCOO --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> * Removed remaining naming dependencies (#654) * Removed remaining naming dependencies * Added to changelog and fixed CI issue * PR feedback * Fixed schema reqs * Update validators to allow zero values for costs for nuclear * Bugfix: Connecting resource to multiple techs (#655) * bugfix and added test for connecting one resource model to multiple techs * updated changelog * Updated test to call setup to trigger connection error --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> * Update urls for NLR pages and github repositories (#658) * Update urls for NLR pages and github repositories * Updated from WISDM to NLRWindSystems org for some repos * Updated and removed more NREL references --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> * Enhancement/windows ci (#590) * update installation instructions * add windows to CI and use conda consistently for Python across OS * merge develop and update changelog * adopt 'extras' flag for analysis extras to correctly use optional CI * update changelog * reorder ci setup * update order * attempt python version restructure * reinstate old python version * update URL * move runs-on back to below strategy * add os to optional matrix * reorganize the conditional for extras * convert lists to yaml bullet lists * skip gis-dependent tests when not installed * update changelog * use optional deps for all tests and add single runner for validating dependency-determined skipped tests * reformatting * reduce sql file access scope to functions to avoid windows errors * downgrade temp_dir to a function scope to avoid windows access errors * move temp examples fixture to be in main conftest, and enable repo-wide access * add module scoped example directory copy * apply module scoped example copy fixture to recorder tests and update * update changelog * update miniconda action usage * use the example copy fixture to isolate sql access in tests for potential windows resolution * reorganize changelog * fix typo in parameter name * update workflow * remove max-parallel * Revert "reorganize changelog" This reverts commit 679a38d. * add shell to all tests * don't allow coverage upload to fail ci * uncomment windows * add garbage collection to help with sql file handling * temporarily only run windows to reduce runner usage * add sleep to see if small timeout resolves issue * only run single test * remove garbage collection * fix typo * remove manual folder removal in favor of pytest cleanup * reinstate normal CI processes * add file removal to avoid OpenMDAO silent failure * temporarily only run single file on single windows runner * fix typo * fix typo * move manual recorder_path deletion * put ci back * handle None case * track model state using IntEnum * add xfail for windows because of OpenMDAO improper SQL file handling for Windows * add todo about removing manual removal * restore accidentally deleted file --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> Co-authored-by: kbrunik <kbrunik@gmail.com> * updated CI workflow to disable windows (#668) * Check for extraneous or mis-categorized input parameters (#647) * added dictionary utilities * bugfix in setup() and added start of a test * added fix to calling check_inputs * fixed check_inputs * added another check in check_inputs * updated error messages in check_inputs and fixed example 1 * Added tests * added another subtest to test_check_inputs * fixed tech configs for examples * added some inline comments * check for requisite models and return if none * perform check from note and collapse checking logic * collapse user input regeneration to reduce number of loops * remove nested looping approach * move assert to proper context manager level * add indent level back * fix min combinations logic for passing tests * flatten improperly shared parameterization checking logic * update test to include multiple categories for improperly shared * fix typo * update docstring * added handling for combined cost and performance models * Added tech config fpath to the error messages for parameter checking * changlog * changed strict to True for six converter models * reverted strict setting for electrolyzer --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> Co-authored-by: Hammond, Rob <13874373+RHammond2@users.noreply.github.com> Co-authored-by: kbrunik <kbrunik@gmail.com> * Update Naming Convention in Open-Loop Converter Control Strategies (#631) * renamed outputs in converter openloop controllers * updated tests and examples with updated naming * added performance model outputs to the converter control strategies * moved converter control strategies to demand folder * removed commodity_set_point as output * renamed demand component to be performance model instead of control strategy * moved output calculations to shared method in baseclass --------- Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> Co-authored-by: John Jasa <johnjasa11@gmail.com> * modified state check for setup and run (#669) * Add interactive class hierarchy visualization to docs (#643) * Added class hierarchy diagram * merging * Updated the PR template * Changed class hierarchy embedding * moved class hierachy * Breaking the sphinx narrow rule * Combined colors based on feedback * Updated colors based on Gen's feedback * Shifted diagram location right * Reformatting embedding the class viz structure * Updated dev pyproject for viz tool --------- Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> * Standardize Feedstock Outputs (follow-on to 463) (#523) * added capacity and price as inputs to feedstock component * updated feedstock mdoel to have standard outputs * added commodity_amount_units to FeedstockCostConfig * added standard output to feedstock cost model and connected commodity_out between performance and cost model * renamed config inputs for feedstocks * updated ex 23 which is untested and cleaned up feedstocks.py * minor docstring updates and added comments * added in notes of questions for reviewers to feedstocks.py * updated MMBtu units to MMBtu/h * fixed iron and steel tests * made changes to feedstock * fixed tests * removed unused comment * removed shape from price input * added integration test for feedstock integrated with finance model * updated feedstocks.md * changed based on reviewer feedback * added subtests to test_feedstocks * small changes to feedstock doc * docs --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> Co-authored-by: kbrunik <kbrunik@gmail.com> Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> * Framework to allow for variable dt (#653) * add draft for variable timestep framework * Changed error wording * switch bounds to tuple * minor test correction * include time-series generation functions * add tests for variable dt and update simulation length check for non-hourly dt * update docs * update changelog * update docs and doc strings * restore develop version of utilities.py * update dt bounds error * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fixing tests * Adding time step bounds to all models * Adding time step bounds to the combiner/splitter/transporters * Updates for tests * Adding time step bounds to the custom paper mill performance model * Added time step bounds to paper mill cost --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> Co-authored-by: John Jasa <john.jasa@nrel.gov> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * patch: Variable dt (#671) * update dt bounds error to require `_time_step_bounds` * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add time step bounds to all tech models * Apply time step bounds check to feedstocks, transporters, and combiners --------- Co-authored-by: John Jasa <johnjasa11@gmail.com> Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> Co-authored-by: John Jasa <john.jasa@nrel.gov> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove system-level outputs from storage and replace with demand component (follow-on to 631) (#666) * removed system level calcs from storage and updated most tests * updated examples with storage but dont use storage as a commodity_stream in finances * updated examples with storage defined as a commodity_stream for a finance subgroup * added time_step_bounds to demand components * added test for example 23 * added example for different demand between storage and demand component * added demo for the demand components using example 13 * made it so demand is only input to battery performance model if using feedback control * added standard_capacity_factor as output from storage * added doc page for storage performance models --------- Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> Co-authored-by: John Jasa <johnjasa11@gmail.com> Co-authored-by: kbrunik <kbrunik@gmail.com> * Updating the readme and intro doc page ahead of v0.8 release (#677) * Updating the readme * Updated intro.md and changelog * Minor readme updates * Addressing Kaitlin's comments * Added more lingo to readme * Addressing PR suggestions --------- Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> * Move storage controllers into `storage` folder in `control_strategies` (#678) * moved controllers to storage folder * renamed pyomo controllers to include storage in the control name * moved control strategy tests * moved tests to the right folder * moved pyomo baseclass and controller_opt_problem_state to top-level control_strategies * updated import statements * renamed pyomo baseclass file * updated import for pyomo storage baseclass * made storage chapter in docs * removed backslashes from eqn since they dont render properly on readthedocs * Making changes per Gen's suggestion (#681) * Bump version from 0.7.2 to 0.8.0 --------- Co-authored-by: kbrunik <102193481+kbrunik@users.noreply.github.com> Co-authored-by: elenya-grant <116225007+elenya-grant@users.noreply.github.com> Co-authored-by: Rob Hammond <13874373+RHammond2@users.noreply.github.com> Co-authored-by: genevievestarke <103534902+genevievestarke@users.noreply.github.com> Co-authored-by: Jared Thomas <jaredthomas68@gmail.com> Co-authored-by: bayc <christopher.j.bay@gmail.com> Co-authored-by: Jared Thomas <jaredthomas68@users.noreply.github.com> Co-authored-by: Jonathan Martin <94018654+jmartin4u@users.noreply.github.com> Co-authored-by: jmartin4 <jonathan.martin@nrel.gov> Co-authored-by: Jonathan Martin <94018654+jmartin4nrel@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Chris Bay <12664940+bayc@users.noreply.github.com> Co-authored-by: Genevieve Starke <genevieve.starke@nrel.gov> Co-authored-by: kbrunik <kbrunik@gmail.com>

elenya-grant added 7 commits February 10, 2026 16:34

added capacity and price as inputs to feedstock component

cdf5f67

updated feedstock mdoel to have standard outputs

de5ef00

added commodity_amount_units to FeedstockCostConfig

2066e16

added standard output to feedstock cost model and connected commodity…

3876418

…_out between performance and cost model

renamed config inputs for feedstocks

dd16235

updated ex 23 which is untested and cleaned up feedstocks.py

78506c1

minor docstring updates and added comments

791e463

elenya-grant requested review from johnjasa and kbrunik February 11, 2026 16:57

elenya-grant added the ready for review This PR is ready for input from folks label Feb 11, 2026

elenya-grant and others added 2 commits February 11, 2026 14:05

added in notes of questions for reviewers to feedstocks.py

a1e94fa

Merge branch 'develop' into feedstock_updates

a04c309

elenya-grant mentioned this pull request Feb 11, 2026

Update ProFAST finance models to use utilization instead of capacity (1 of 3) #485

Closed

11 tasks

elenya-grant added 5 commits February 12, 2026 10:08

updated MMBtu units to MMBtu/h

4747d2f

Merge branch 'feedstock_updates' of github.com:elenya-grant/GreenHEAR…

5744889

…T into feedstock_updates

Merge remote-tracking branch 'h2i_upstream/develop' into feedstock_up…

efd9044

…dates

fixed iron and steel tests

a42b637

Merge remote-tracking branch 'h2i_upstream/develop' into feedstock_up…

0944851

…dates

elenya-grant added the high priority label Feb 13, 2026

johnjasa and others added 3 commits February 13, 2026 15:28

Merge branch 'develop' into feedstock_updates

d823344

Merge remote-tracking branch 'h2i_upstream/develop' into feedstock_up…

ab5a2cf

…dates

Merge branch 'feedstock_updates' of github.com:elenya-grant/GreenHEAR…

13c7dba

…T into feedstock_updates

elenya-grant mentioned this pull request Feb 13, 2026

Update natural gas units #522

Closed

johnjasa reviewed Feb 13, 2026

View reviewed changes

Comment thread h2integrate/core/feedstocks.py Outdated

elenya-grant and others added 2 commits February 13, 2026 15:53

made changes to feedstock

015c288

Merge branch 'develop' into feedstock_updates

d0da77b

johnjasa requested changes Feb 16, 2026

View reviewed changes

johnjasa closed this Feb 17, 2026

merged in develop

282b533

elenya-grant removed the ready for review This PR is ready for input from folks label Apr 6, 2026

elenya-grant and others added 2 commits April 6, 2026 12:47

removed shape from price input

706d856

Merge branch 'develop' into feedstock_updates

845db9a

elenya-grant requested a review from johnjasa April 7, 2026 21:40

elenya-grant added the ready for review This PR is ready for input from folks label Apr 7, 2026

elenya-grant mentioned this pull request Apr 7, 2026

Update units handling to account for non-mass and non-electricity commodities #659

Open

elenya-grant added 2 commits April 7, 2026 16:18

added integration test for feedstock integrated with finance model

1c1842a

updated feedstocks.md

c9bf5f7

elenya-grant marked this pull request as ready for review April 7, 2026 22:24

Merge branch 'develop' into feedstock_updates

c7228c8

kbrunik requested changes Apr 8, 2026

View reviewed changes

Comment thread h2integrate/core/test/test_feedstocks.py Outdated

Comment thread h2integrate/core/test/test_feedstocks.py Outdated

johnjasa and others added 5 commits April 9, 2026 15:15

Merge branch 'develop' into feedstock_updates

cb74b77

changed based on reviewer feedback

7d316b1

merged changelog

630e527

Merge branch 'feedstock_updates' of github.com:elenya-grant/GreenHEAR…

10b32b4

…T into feedstock_updates

added subtests to test_feedstocks

1637abb

elenya-grant requested a review from kbrunik April 9, 2026 20:29

johnjasa and others added 3 commits April 10, 2026 15:52

Merge branch 'develop' into feedstock_updates

8fc7fee

small changes to feedstock doc

3e5b254

docs

c0615d6

kbrunik approved these changes Apr 10, 2026

View reviewed changes

kbrunik and others added 2 commits April 10, 2026 17:31

Merge branch 'develop' into feedstock_updates

e064d54

Merge branch 'develop' into feedstock_updates

7d0ac16

johnjasa approved these changes Apr 11, 2026

View reviewed changes

johnjasa enabled auto-merge (squash) April 11, 2026 05:18

johnjasa merged commit 1caa9f6 into NatLabRockies:develop Apr 11, 2026
12 checks passed

johnjasa mentioned this pull request Apr 15, 2026

Develop -> Main for v0.8 release #682

Merged

johnjasa mentioned this pull request Apr 16, 2026

Develop -> Main for v0.8 release (#682) #683

Merged

51 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Standardize Feedstock Outputs (follow-on to 463)#523

Standardize Feedstock Outputs (follow-on to 463)#523
johnjasa merged 38 commits intoNatLabRockies:developfrom
elenya-grant:feedstock_updates

elenya-grant commented Feb 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

johnjasa commented Feb 13, 2026

Uh oh!

johnjasa left a comment

Uh oh!

johnjasa Feb 16, 2026

Uh oh!

elenya-grant Apr 7, 2026

Uh oh!

johnjasa Feb 16, 2026

Uh oh!

elenya-grant Apr 8, 2026

Uh oh!

kbrunik left a comment

Uh oh!

Uh oh!

Uh oh!

elenya-grant commented Apr 9, 2026

Uh oh!

kbrunik left a comment

Uh oh!

johnjasa left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

elenya-grant commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Standardize Feedstock Outputs (follow-on to 463)

Section 1: Type of Contribution

Section 2: Draft PR Checklist

TODO:

Type of Reviewer Feedback Requested (on Draft PR)

Section 3: General PR Checklist

Section 3: Related Issues

Section 4: Impacted Areas of the Software

Section 4.1: New Files

Section 4.2: Modified Files

Section 5: Additional Supporting Information

Section 6: Test Results, if applicable

Uh oh!

Uh oh!

johnjasa commented Feb 13, 2026

Uh oh!

johnjasa left a comment

Choose a reason for hiding this comment

Uh oh!

johnjasa Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

elenya-grant Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

johnjasa Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

elenya-grant Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

kbrunik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elenya-grant commented Apr 9, 2026

Uh oh!

kbrunik left a comment

Choose a reason for hiding this comment

Uh oh!

johnjasa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

elenya-grant commented Feb 11, 2026 •

edited

Loading