fix(webapp): improve error feedback on plan upgrade flows#5780
Open
fix(webapp): improve error feedback on plan upgrade flows#5780
Conversation
<!-- Describe the problem and your solution --> Customers faced with errors during attempts to upgrade their plan would receive generic, transient error messages, making it harder for them to pinpoint the root cause of the failure. - Fixed load animation getting stuck on upgrade-plan failures. - Improved error messages displayed to users on upgrade-plan failures: the errors are no longer transient (via toast), but are rather inlined with the <Alert> component. <!-- Issue ticket number and link (if applicable) --> <!-- Testing instructions (skip if just adding/editing providers) --> Register a valid card as a payment method, but set it up to fail when upgrading the plan (e.g. due to lack of funds/limits). The error should now be visible within the upgrade form and the source (if card-related) should be clear.
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review found no issues; changes improve upgrade-flow error clarity and failure handling.
Status: No Issues Found | Risk: Low
Review Details
📁 2 files reviewed | 💬 0 comments
Instruction Files
└── .claude/
├── agents/
│ └── nango-docs-migrator.md
└── skills
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customers faced with errors during attempts to upgrade their plan would receive generic, transient error messages, making it harder for them to pinpoint the root cause of the failure.
- Fixed load animation getting stuck on upgrade-plan failures.
- Improved error messages displayed to users on upgrade-plan failures: the errors are no longer transient (via toast), but are rather inlined with the component.
Register a valid card as a payment method, but set it up to fail when upgrading the plan (e.g. due to lack of funds/limits). The error should now be visible within the upgrade form and the source (if card-related) should be clear.This PR also strengthens upgrade error handling logic by introducing explicit dialog-level error state management and better failure-path cleanup, so errors are consistently reset across dialog lifecycle transitions and retries. In addition, it improves payment-failure clarity by distinguishing card-related Stripe failures from generic payment validation failures, making upgrade issues more actionable while keeping behavior localized to the plan-change flow.
This summary was automatically generated by @propel-code-bot