Merged
Conversation
TBonnin
requested changes
Apr 1, 2026
TBonnin
reviewed
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Review found no issues; lock race-condition fixes and atomic KV operations look sound.
Status: No Issues Found | Risk: Low
Review Details
📁 9 files reviewed | 💬 0 comments
Instruction Files
└── .claude/
├── agents/
│ └── nango-docs-migrator.md
└── skills
TBonnin
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
KVLocksrace conditions with atomicKVStorecompare-and-mutate operationsThis PR is a significant lock correctness update focused on preventing stale-owner races in
KVLocks. The lock implementation inpackages/runner/lib/sdk/locks.tsis rewritten to useKVStoredirectly (instead ofLocking), with stable logical lock keys (runner:lock:+ hash of logical key), owner value checks, and companion owner-index keys to support safe acquire/refresh/release/release-all behavior.To support this, the
KVStoreinterface is extended with atomic compare-and-mutate APIs (including companion-key variants), implemented in bothpackages/kvstore/lib/InMemoryStore.tsandpackages/kvstore/lib/RedisStore.ts(Redis via LuaEVALscripts). Runtime wiring inpackages/lambda-runner/lib/index.tsnow passesKVStoretoKVLocks, and tests were substantially expanded across lock/store unit and integration suites to validate concurrency and race regressions.This summary was automatically generated by @propel-code-bot