Conversation
There was a problem hiding this comment.
Documentation updates are needed to correct required fields, links, and typos for SAP Ariba guides.
Status: Action Required | Risk: Medium
Issues Identified & Suggestions
- Correct required ANID vs Realm guidance and steps:
docs/integrations/all/sap-ariba/connect.mdx - Update Functions guide link to new path:
docs/snippets/generated/sap-ariba/PreBuiltUseCases.mdx - Fix spelling/typos in prerequisites and type safety text:
docs/integrations/all/sap-ariba.mdx,docs/snippets/generated/sap-ariba/PreBuiltTooling.mdx
Review Details
📁 8 files reviewed | 💬 4 comments
Instruction Files
└── .claude/
├── agents/
│ └── nango-docs-migrator.md
└── skills
👍 / 👎 individual comments to help improve reviews for you
| 2. **Client Secret** - A confidential key used to authenticate the identity of your application. | ||
| 3. **Region** - Your SAP Ariba data center region (US, EU, or Australia). | ||
| 4. **Application Key (API Key)** - Required for all API requests. | ||
| 5. **Realm** - Your organization's identifier in SAP Ariba. |
There was a problem hiding this comment.
[Documentation] The Connect guide lists Realm as a required field (lines 13 and Step 3), but the integration config uses anid (Ariba Network ID) and injects it into the X-ARIBA-NETWORK-ID header. If users follow this guide, they'll enter the wrong value and API requests will fail.
Update the guide to request Ariba Network ID (ANID) instead of Realm and rename Step 3 accordingly (e.g., “Find Your ANID”). If Realm is also required, add it explicitly to the connection config and headers.
Context for Agents
The Connect guide lists **Realm** as a required field (lines 13 and Step 3), but the integration config uses `anid` (Ariba Network ID) and injects it into the `X-ARIBA-NETWORK-ID` header. If users follow this guide, they'll enter the wrong value and API requests will fail.
Update the guide to request **Ariba Network ID (ANID)** instead of Realm and rename Step 3 accordingly (e.g., “Find Your ANID”). If Realm is also required, add it explicitly to the connection config and headers.
File: docs/integrations/all/sap-ariba/connect.mdx
Line: 13| @@ -0,0 +1,3 @@ | |||
| _No pre-built syncs or actions available yet._ | |||
|
|
|||
| <Tip>Not seeing the integration you need? [Build your own](https://nango.dev/docs/guides/platform/functions) independently.</Tip> No newline at end of file | |||
There was a problem hiding this comment.
[Documentation] The empty-state snippet should link to the Functions guide at /docs/guides/primitives/functions. The current link points to /docs/guides/platform/functions, which is the old path.
| <Tip>Not seeing the integration you need? [Build your own](https://nango.dev/docs/guides/platform/functions) independently.</Tip> | |
| <Tip>Not seeing the integration you need? [Build your own](https://nango.dev/docs/guides/primitives/functions) independently.</Tip> |
Context for Agents
[FileRule: .claude/agents/nango-docs-migrator.md] The empty-state snippet should link to the Functions guide at `/docs/guides/primitives/functions`. The current link points to `/docs/guides/platform/functions`, which is the old path.
```suggestion
<Tip>Not seeing the integration you need? [Build your own](https://nango.dev/docs/guides/primitives/functions) independently.</Tip>
```
File: docs/snippets/generated/sap-ariba/PreBuiltUseCases.mdx
Line: 3💡 Applied from Instructions File: .claude/agents/nango-docs-migrator.md
| <Overview /> | ||
|
|
||
| ## Access requirements | ||
| | Pre-Requisites | Status | Comment| |
| | Tools | Status | | ||
| | - | - | | ||
| | HTTP request logging | ✅ | | ||
| | End-to-type type safety | ✅ | |
There was a problem hiding this comment.
Description
Adds SAP Ariba as a new integration provider with OAuth2 Client Credentials (OAUTH2_CC) authentication.
What's included:
providers.yamlwith support for regional endpoints (US, EU, Australia)openapi_2lo(SAP Ariba's non-standard grant type instead ofclient_credentials)apikeyandX-ARIBA-NETWORK-IDheaders, plusretry-aftersupportconnection.service.ts. Switched frominterpolateString(which strippedconnectionConfig.prefix) tointerpolateStringFromObject(which properly resolves nested${connectionConfig.*}references). This is needed because SAP Ariba's token URL uses${connectionConfig.region}with a fallback (||) pattern.Testing
The interpolation change was verified locally by:
sap-ariba-testintegration via the APIoauth2_cc_error(expected with dummy credentials)Also tested a successful call against the SAP Ariba API with our credentials.
It also updates the provider schema to recognize the
openapi_2logrant type and registers the new SAP Ariba documentation in the docs navigation.This summary was automatically generated by @propel-code-bot