fix(connections): preserve tags on reconnect when no tags are provided

[hassan254-prog]

Describe the problem and your solution

• preserve tags on reconnect when no tags are provided

---

Fix reconnect tag preservation in upsertAuthConnection

This PR updates upsertAuthConnection to preserve existing connection tags when reconnecting with empty tags, while still replacing tags when non-empty values are provided. It also adds integration tests to validate both behaviors.

---

This summary was automatically generated by @propel-code-bot

[propel-code-bot]

Suggested changes highlight a potential regression in tag-clearing behavior when reconnecting with empty tags.

Status: Changes Suggested | Risk: Medium

Issues Identified & Suggestions

• Clarify or add explicit tag-clearing mechanism for empty tags connection.service.ts

Review Details

📁 2 files reviewed | 💬 1 comments

Instruction Files

└── .claude/
    ├── agents/
    │   └── nango-docs-migrator.md
    └── skills

👍 / 👎 individual comments to help improve reviews for you

[propel-code-bot]

[Logic] This change treats {} as “preserve existing tags.” That makes it impossible to clear tags by reconnecting with an empty object, which previously resulted in tags being cleared. If clients rely on clearing tags via {}, we need an explicit way to clear (e.g., tags: null or a separate preserveTags/clearTags flag) or update callers/docs accordingly. Is clearing tags still supported after this change?

Context for Agents

This change treats `{}` as “preserve existing tags.” That makes it impossible to clear tags by reconnecting with an empty object, which previously resulted in tags being cleared. If clients rely on clearing tags via `{}`, we need an explicit way to clear (e.g., `tags: null` or a separate `preserveTags`/`clearTags` flag) or update callers/docs accordingly. Is clearing tags still supported after this change?

File: packages/shared/lib/services/connection.service.ts
Line: 219