Skip to content

fix: handle empty publicStripeKey to prevent frontend crash (#5640) Additional changes #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iroussos25 wants to merge 7 commits into
base: master
Choose a base branch
from
+7 −3
Open

fix: handle empty publicStripeKey to prevent frontend crash (#5640) Additional changes #5641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b91867e
fix: complete Stripe key handling for self-hosted and billing safety
iroussos25 Mar 18, 2026
232e8d8
Merge branch 'master' into master
iroussos25 Mar 18, 2026
d4d1456
Merge branch 'master' into master
iroussos25 Mar 19, 2026
f510772
Merge branch 'master' into master
iroussos25 Mar 21, 2026
1c38c29
Merge branch 'master' into fix/stripe-public-key-null-check
iroussos25 Apr 7, 2026
f22aa00
Merge branch 'master' into fix/stripe-public-key-null-check
iroussos25 Apr 10, 2026
8d73233
Merge branch 'master' into fix/stripe-public-key-null-check
iroussos25 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/billing/lib/stripe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ import Stripe from 'stripe';
import { envs } from './envs.js';

export function getStripe() {
return new Stripe(envs.STRIPE_SECRET_KEY!, {
if (!envs.STRIPE_SECRET_KEY) {
throw new Error('STRIPE_SECRET_KEY is required to initialize Stripe');
}

return new Stripe(envs.STRIPE_SECRET_KEY, {
apiVersion: '2025-05-28.basil',
typescript: true,
telemetry: false
Expand Down
2 changes: 1 addition & 1 deletion packages/server/lib/controllers/v1/getEnvJs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const getEnvJs = asyncWrapper<any, any>((_, res) => {
publicPosthogKey: envs.PUBLIC_POSTHOG_KEY || '',
publicPosthogHost: envs.PUBLIC_POSTHOG_HOST || '',
publicLogoDevKey: envs.PUBLIC_LOGODEV_KEY || '',
publicStripeKey: envs.PUBLIC_STRIPE_KEY || '',
publicStripeKey: envs.PUBLIC_STRIPE_KEY || undefined,
isCloud,
isHosted,
isEnterprise,
Expand Down
2 changes: 1 addition & 1 deletion packages/types/lib/web/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export interface WindowEnv {
publicPosthogKey: string;
publicPosthogHost: string;
publicLogoDevKey: string;
publicStripeKey: string;
publicStripeKey: string | undefined;
isCloud: boolean;
isHosted: boolean;
isEnterprise: boolean;
Expand Down