Skip to content

[CORE-371] Fix Form List Deadline Filter for Null-Deadline Forms#186

Open
dytsou wants to merge 4 commits into
mainfrom
fix/CORE-371-deadline-null-filter
Open

[CORE-371] Fix Form List Deadline Filter for Null-Deadline Forms#186
dytsou wants to merge 4 commits into
mainfrom
fix/CORE-371-deadline-null-filter

Conversation

@dytsou

@dytsou dytsou commented Jun 28, 2026

Copy link
Copy Markdown
Member

Type of changes

  • Fix
  • Test

Purpose

  • Include forms with deadline IS NULL when excludeExpired=true in form list query
  • Add integration tests for ListExcludeExpired behavior
  • Resolve issue CORE-371

Additional Information

@dytsou dytsou requested review from Dada8825252 and S-h-u-a-n June 28, 2026 07:39
@dytsou dytsou self-assigned this Jun 28, 2026
@dytsou dytsou changed the title [CORE-371] Fix form list deadline filter for null-deadline forms [CORE-371] Fix Form List Deadline Filter for Null-Deadline Forms Jun 28, 2026
@Dada8825252

Copy link
Copy Markdown
Contributor

Could you fix the mixed receiver issue in response/service.go? GetEditInfo uses a pointer receiver while all other Service methods use value receivers — Go recommends keeping them consistent within a type. Since the struct holds multiple dependencies, standardizing on pointer receivers across all methods would be the more idiomatic choice.

Comment thread internal/form/response/service.go Outdated
@dytsou dytsou force-pushed the fix/CORE-371-deadline-null-filter branch from 4159392 to ef1551e Compare July 3, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants