Skip to content

Conversation

@YanxuanLiu
Copy link
Collaborator

@YanxuanLiu YanxuanLiu requested a review from a team as a code owner August 19, 2025 06:50
@YanxuanLiu YanxuanLiu self-assigned this Aug 19, 2025
@YanxuanLiu YanxuanLiu requested a review from Copilot August 19, 2025 06:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enhances the markdown link check GitHub action by adding support for all available parameters from the underlying tcort/github-action-markdown-link-check action. This change makes the shared action more flexible and configurable for different use cases.

  • Adds comprehensive input parameters for markdown link checking configuration
  • Replaces hardcoded values with configurable inputs and appropriate defaults
  • Updates the workflow to demonstrate usage of the new input parameters

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
markdown-link-check/action.yml Adds input parameters and replaces hardcoded values with configurable inputs
.github/workflows/markdown-link-check.yml Demonstrates usage of new input parameters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

required: false
base-branch:
description: 'Comparison branch for modified files check'
required: false
Copy link

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base-branch parameter was previously hardcoded to 'gh-pages' but now has no default value. Consider adding a default value or documenting the expected behavior when this parameter is not provided.

Suggested change
required: false
required: false
default: 'gh-pages'

Copilot uses AI. Check for mistakes.
@YanxuanLiu YanxuanLiu merged commit 0297c7b into NVIDIA:main Aug 19, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants