Shellcheck shared action #44
Conversation
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new reusable ShellCheck GitHub Action and refactors the existing workflow to use it. The action provides a configurable shell script linting solution with predefined exclusions for common ShellCheck warnings.
Key changes:
- Creates a new shared ShellCheck action with configurable excluded error codes
- Simplifies the existing shell-check workflow by using the new shared action
- Removes unnecessary fetch-depth configuration from the workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| shell-check/action.yml | New shared action that configures ShellCheck with predefined exclusions and allows additional user-specified exclusions |
| .github/workflows/shell-check.yml | Simplified workflow that now uses the new shared action instead of directly calling ludeeus/action-shellcheck |
Comments suppressed due to low confidence (1)
.github/workflows/shell-check.yml
Outdated
| echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 10 ))" >> $GITHUB_ENV | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
the checkout would be better to not be put at the caller side, as mentioned before, otherwise you will need to update all refs later in multiple places in the future
There was a problem hiding this comment.
BTW license header check has the same issue, please help fix all refs when available
There was a problem hiding this comment.
Sure. will file another PR for a checkout wrapper
pxLi
left a comment
pxLi
left a comment
There was a problem hiding this comment.
Please help do some post-merge verification after force merge thanks
Signed-off-by: Yanxuan Liu <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
test PR: #47 |
3 participants
Add shellcheck shared action