Skip to content

add license header check v2 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 10, 2025
Merged

add license header check v2 #38

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e8c6772
add license header check v2
YanxuanLiu Jun 6, 2025
ea550d7
fix nits
YanxuanLiu Jun 6, 2025
b4673ec
fix nits
YanxuanLiu Jun 6, 2025
33d9978
add conditional branch
YanxuanLiu Jun 9, 2025
4fabc7c
fix
YanxuanLiu Jun 9, 2025
218158d
test
YanxuanLiu Jun 9, 2025
d8af00b
update desc
YanxuanLiu Jun 9, 2025
efaedfa
fix nits
YanxuanLiu Jun 10, 2025
439d63e
optimize
YanxuanLiu Jun 10, 2025
b9f8f8d
fix nits
YanxuanLiu Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/license-header-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,4 @@ jobs:
*Dockerfile*,
auto-merge/automerge,
signoff-check/signoff-check
check_main: true
15 changes: 11 additions & 4 deletions license-header-check/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ inputs:
description: "excluded file pattern"
required: false
type: string
check_main:
description: "check main branch or not"
required: false
type: boolean
default: false

runs:
using: "composite"
Expand All @@ -36,10 +41,12 @@ runs:
CURRENT_YEAR=$(date +%Y)
LICENSE_PATTERN="Copyright \(c\) .*?${CURRENT_YEAR},? NVIDIA CORPORATION."

# Skip for merge to main PR
if [[ "${{ github.event.pull_request.base.ref }}" == "main" ]]; then
echo "Skip this check for Merge to main PR."
exit 0
# Skip check for main branch when check_main == false
if [[ "${{ inputs.check_main }}" == "false" ]]; then
if [[ "${{ github.event.pull_request.base.ref }}" == "main" ]]; then
echo "Skip this check for Merge to main PR."
exit 0
fi
Copy link

Copilot AI Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The nested if blocks around check_main can be simplified into a single conditional to improve readability, for example: if [[ "${{ inputs.check_main }}" == "false" && "${{ github.event.pull_request.base.ref }}" == "main" ]]; then ... fi.

Suggested change
if [[ "${{ inputs.check_main }}" == "false" ]]; then
if [[ "${{ github.event.pull_request.base.ref }}" == "main" ]]; then
echo "Skip this check for Merge to main PR."
exit 0
fi
if [[ "${{ inputs.check_main }}" == "false" && "${{ github.event.pull_request.base.ref }}" == "main" ]]; then
echo "Skip this check for Merge to main PR."
exit 0
fi

Copilot uses AI. Check for mistakes.
fi

# Format file patterns
Expand Down
Loading