feat(operator): add strict ordering of Skyhooks using priority and name #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ayuskauskas merged 5 commits into main from strict_order

Jun 3, 2025

Collaborator

ayuskauskas commented May 20, 2025

No description provided.

ayuskauskas requested review from lockwobr and mskalka as code owners

May 20, 2025 01:14

lockwobr reviewed

View reviewed changes

chart/templates/skyhook-crd.yaml Outdated Show resolved Hide resolved

lockwobr reviewed

View reviewed changes

k8s-tests/chainsaw/skyhook/cleanup-pods/chainsaw-test.yaml Outdated Show resolved Hide resolved

lockwobr reviewed

View reviewed changes

operator/internal/controller/skyhook_controller.go Outdated Show resolved Hide resolved

ayuskauskas force-pushed the strict_order branch from e6356de to d305d9c Compare

May 20, 2025 20:54


          feat(operator): add strict ordering of skyhooks along with documentation

f81fc82

ayuskauskas force-pushed the strict_order branch from 33800ba to f81fc82 Compare

May 23, 2025 16:22

ayuskauskas changed the title ~~Strict order~~ feat(operator): add strict ordering of Skyhooks using priority and name

lockwobr reviewed

View reviewed changes

docs/ordering_of_skyhooks.md Outdated Show resolved Hide resolved

lockwobr reviewed

View reviewed changes

k8s-tests/chainsaw/skyhook/strict_order/assert-c.yaml Show resolved Hide resolved

lockwobr reviewed

View reviewed changes

operator/Makefile Outdated Show resolved Hide resolved

lockwobr reviewed

View reviewed changes

k8s-tests/chainsaw/skyhook/validate-packages/chainsaw-test.yaml Outdated Show resolved Hide resolved

lockwobr reviewed

View reviewed changes

operator/api/v1alpha1/skyhook_types.go Outdated Show resolved Hide resolved

lockwobr reviewed

View reviewed changes

operator/internal/controller/skyhook_controller.go Outdated Show resolved Hide resolved

lockwobr reviewed

View reviewed changes

operator/internal/controller/skyhook_controller.go Outdated Show resolved Hide resolved

ayuskauskas added 3 commits

May 30, 2025 14:37


          fix: reviews

cf40118


          fix(e2e): increase strict order time to allow asserts to go

75bb80d


          fix(operator): change minimum to be 1 due to 0 being considered an 'u…

afc1105

…nset' value for golang

lockwobr reviewed

View reviewed changes

chart/templates/skyhook-crd.yaml Outdated Show resolved Hide resolved

lockwobr reviewed

View reviewed changes

docs/ordering_of_skyhooks.md Outdated Show resolved Hide resolved

lockwobr reviewed

View reviewed changes

k8s-tests/chainsaw/skyhook/simple-skyhook/chainsaw-test.yaml Outdated Show resolved Hide resolved


          fix(operator): missed changes related to changing min value for priority

3e075c7

lockwobr approved these changes

View reviewed changes

ayuskauskas merged commit 930d616 into main

3 checks passed

ayuskauskas deleted the strict_order branch

June 3, 2025 21:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet