Skip to content

Conversation

@t0mmylam
Copy link
Collaborator

Makes failureThreshold nullable in DeploymentPolicy strategies, allowing rollouts to continue indefinitely despite consecutive batch failures when the field is omitted.

Changes

  • API Types: Removed failureThreshold from default value assignment in webhook
  • Logic: Updated getFailureThreshold() to return *int and modified EvaluateBatchResult() to only stop rollouts when failureThreshold is explicitly set
  • Docs: Clarified that DeploymentPolicy controls all node updates (not just interrupts) and documented nullable failureThreshold behavior
  • Samples: Updated example YAMLs to demonstrate both explicit and omitted failureThreshold use cases
  • Tests: Updated test expectations to verify failureThreshold remains nil after defaulting

@t0mmylam t0mmylam merged commit d687731 into main Nov 12, 2025
7 checks passed
@t0mmylam t0mmylam deleted the feature/nullable-consecutive-failures branch November 12, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants