-
Notifications
You must be signed in to change notification settings - Fork 393
PyTorch Geometric support in MeshGraphNet #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Alexey-Kamenev
merged 20 commits into
NVIDIA:main
from
Alexey-Kamenev:pyg-vortex-shedding
Jul 11, 2025
Merged
PyTorch Geometric support in MeshGraphNet #995
Alexey-Kamenev
merged 20 commits into
NVIDIA:main
from
Alexey-Kamenev:pyg-vortex-shedding
Jul 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GL inference script.
/blossom-ci |
/blossom-ci |
nit: The requirements.txt should include torch_scatter. I got it to work with
|
Good point - done! |
/blossom-ci |
/blossom-ci |
mnabian
reviewed
Jul 9, 2025
mnabian
reviewed
Jul 9, 2025
mnabian
reviewed
Jul 9, 2025
/blossom-ci |
/blossom-ci |
ktangsali
reviewed
Jul 9, 2025
ktangsali
approved these changes
Jul 9, 2025
mnabian
approved these changes
Jul 10, 2025
/blossom-ci |
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
The document describing the general approach is available here.
Key Changes
VortexSheddingDataset
datapipe.Features
vortex_shedding_mgn_dgl
.vortex_shedding_mgn
.Breaking Changes
with the new PyG implementation. Users will need to change the corresponding datapipe
to load DGLGraph objects and convert them to PyG objects.
Out of scope
Advanced features are not included or not validated in this PR, such as:
Known Issues
DGL vs PyG loss curves in vortex shedding example. PyG loss curve has too much variance. 1379Checklist
Dependencies