Skip to content

Throw exception when directory not found #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Throw exception when directory not found #987

wants to merge 1 commit into from

Conversation

emmanuel-ferdman
Copy link
Contributor

PhysicsNeMo Pull Request

Description

This small PR fixes the utils function get_filenames to throw an exception when directory not found.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@peterdsharpe
Copy link
Collaborator

Thank you for the PR, @emmanuel-ferdman, and definitely a good catch here!

This issue is fixed in the refactor of PR #985 -- however, I'll leave this PR open until #985 is merged so we don't lose track of this issue. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuel-ferdman @peterdsharpe