-
Notifications
You must be signed in to change notification settings - Fork 399
Fix casting in SongUNetPosEmbd and shape in CorrDiff generation #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
23f79b5
Fix regression output shape
bab3815
Only use act if fused_act is True
f124ba9
Avoid dtype change of buffer/param and fix softmax dtype
2a817f7
Merge branch 'main' into jberner/fix_corrdiff
CharlelieLrt 12f502f
Added unit tests for song unet models with learnable positional embed…
CharlelieLrt ab4c29b
Merge branch 'main' into jberner/fix_corrdiff
CharlelieLrt 4a3855f
Merge branch 'main' into jberner/fix_corrdiff
CharlelieLrt 0fbd457
Updated tests for SongUNetPosLtEmbd with AMP, Apex GN and compile
CharlelieLrt 7117a0e
Renamed variable in SongUNetPOsEmbd
CharlelieLrt 13ee002
Merge branch 'main' into jberner/fix_corrdiff
CharlelieLrt 734b296
Revert bug introduced in SongUNetPosEmbd positional_embedding_selector
CharlelieLrt 1cbf602
Reverted test script to its original state
CharlelieLrt 7ad0212
Fixed some new CI tests
CharlelieLrt 9d5ce7d
Added missing parameter in new tests
CharlelieLrt 7fda836
Added dtype casting in SongUNetPosEmbd forward
CharlelieLrt 81d1d30
Fixed number of channels in new tests
CharlelieLrt a0d0b16
Added random seed in new tests
CharlelieLrt ad57c14
Added more missing random seeds to new tests
CharlelieLrt 997d54e
Removed some random seeds added by mistake in new tests
CharlelieLrt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+2.3 MB
test/models/data/songunet_pos_lt_embd_pos_embed_indexing_no_patches_corrdiff.pth
Binary file not shown.
Binary file added
BIN
+1.31 MB
test/models/data/songunet_pos_lt_embd_pos_embed_indexing_with_patches_corrdiff.pth
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.