Generalize the encode_parameter in DoMINO to any arbitrary no. of global parameters input
#903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a copy of #877 that was raised against the |
|
I have tested end-to-end training for |
There was a problem hiding this comment.
This looks good. A few general comments:
- Look at pytest in physicsnemo/test and modify the domino tests accordingly to reflect these changes
- Modify changelog.md with description of what is done here
- Rebase with physicsnemo main
- Run pre-commit and fix formatting issues
examples/cfd/external_aerodynamics/domino/src/inference_on_stl.py
Outdated
Show resolved
Hide resolved
|
@ktangsali can you please run blossom on this PR? |
|
/blossom-ci |
RishikeshRanade
approved these changes
Jul 15, 2025
|
/blossom-ci |
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
|
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
This PR modifies conf.yaml, model.py and domino_datapipe.py to allow for arbitrary number of input global parameters instead of being restricted to inlet_velocity, air_density. examples/external_aerodynamics/cfd/domino is accordingly modified and tested on DrivAer dataset.
Checklist
Dependencies