-
Notifications
You must be signed in to change notification settings - Fork 393
Fixes for test collection and guards for missing PhysicsNeMo-Sym #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ript file collection using pathlib to fix collection errors.
…equired, but currently is)
…sicsnemo into psharpe/test_collection
/blossom-ci |
/blossom-ci |
@@ -70,11 +70,14 @@ class MdlsUNetMetaData(ModelMetaData): | |||
# [physicsnemo model] | |||
|
|||
# [physicsnemo sym model] | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When does this failure occur? The code snippet here is rendered in the docs, and the try-except will not look good. For running pytest in the root directory, make pytest
should be preferred. I can see the rationale of supporting pytest .
too, but unforutnately this does not work in the present setting. Maybe something like below is better to modify the default behavior of pytest (reference):
[tool.pytest.ini_options]
testpaths = ["test"]
or perhaps a .pytest.ini
file
PhysicsNeMo Pull Request
Description
Addresses two bugs:
pytest .
from root caused an error in test collection due to path issues intest_runner.py
. Fixed this, and refactored to use the more-modernpathlib
builtin library instead ofos.path
. (In general, going forward, we should typically preferpathlib
overos.path
)This provides a fix for the first bug, and at least a more graceful failure for the second bug.
Checklist
Dependencies