Skip to content

Removed zip compression when saving checkpoints #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2025
+1 −1
Merged

Removed zip compression when saving checkpoints #1210

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2d07ce
Removed zip compression
CharlelieLrt Nov 4, 2025
718d20c
Merge branch 'main' into bugfix-checkpoints-zip-overhead
CharlelieLrt Nov 4, 2025
b0e3337
Merge branch 'main' into bugfix-checkpoints-zip-overhead
coreyjadams Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion physicsnemo/models/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ def _save_process(module, args, metadata, mod_prefix="") -> None:
with tempfile.NamedTemporaryFile(suffix=".zip", delete=False) as tmp:
tmp_path = tmp.name

with zipfile.ZipFile(tmp_path, "w", zipfile.ZIP_DEFLATED) as archive:
with zipfile.ZipFile(tmp_path, "w", zipfile.ZIP_STORED) as archive:
# Save model state dict
state_dict_buffer = io.BytesIO()
torch.save(self.state_dict(), state_dict_buffer)
Expand Down