Solve checkpoint and validation bugs in training corrdiff unet #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y script as the regression loss does not support it
|
@CharlelieLrt Can you please review it? |
CharlelieLrt
requested changes
Jul 12, 2025
…me dimension used to name the layers
CharlelieLrt
requested changes
Jul 15, 2025
Comment on lines
-1156
to
+1154
| idx_x = torch.arange(self.img_shape_y) | ||
| idx_y = torch.arange(self.img_shape_x) | ||
| mesh_x, mesh_y = torch.meshgrid(idx_x, idx_y) | ||
| grid = torch.stack((mesh_x, mesh_y), dim=0) # (2, img_shape_y, img_shape_x) | ||
| idx_x = torch.arange(self.img_shape_x) | ||
| idx_y = torch.arange(self.img_shape_y) | ||
| mesh_y, mesh_x = torch.meshgrid(idx_y, idx_x) | ||
| grid = torch.stack((mesh_y, mesh_x), dim=0) # (2, img_shape_y, img_shape_x) |
There was a problem hiding this comment.
Your changes are consistent with the original implementation, but I think the original implementation is wrong.
If you look at the shape of grid, I think it is transposed in comparison to the case self.gridtype == "linear".
The case self.gridtype == "test" is only used in CI tests, but it might be better to fix the implementation + fix any test that is failing (probably not many because we have only very few tests for non-square images)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #994 .