Skip to content

Conversation

@zhanluxianshen
Copy link
Contributor

@zhanluxianshen zhanluxianshen commented Nov 8, 2024

1 Use simple grammar in fsnotify package.

This makes checking events a lot easier; for example:

  if event.Op&Write == Write && !(event.Op&Remove == Remove) {
  }
Becomes:

  if event.Has(Write) && !event.Has(Remove) {
  }

According fsnotify notes

Fix Remove event.

@tariq1890 tariq1890 requested a review from elezar November 8, 2024 19:06
@elezar elezar merged commit 21ba993 into NVIDIA:main Nov 29, 2024
10 checks passed
@zhanluxianshen zhanluxianshen deleted the fix-fsnotify-logic branch November 29, 2024 13:29
@zhanluxianshen
Copy link
Contributor Author

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants