Fix race condition in mounts cache #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
added
the
must-backport
elezar
removed
the
must-backport
elezar
force-pushed
the
use-with-cache-for-mounts
branch
from
7352a90 to
b4c8eba
Compare
elezar
force-pushed
the
use-with-cache-for-mounts
branch
from
b4c8eba to
242af51
Compare
jgehrcke
approved these changes
Mar 21, 2025
jgehrcke
left a comment
jgehrcke
left a comment
There was a problem hiding this comment.
Thank you. I trust you know what you are doing.
This change switches to using the WithCache decorator for mounts instead of keeping track of a cache locally. This addresses a race condition when using the mounts structure. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
use-with-cache-for-mounts
branch
from
242af51 to
986f3db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches to using the WithCache decorator for mounts instead of keeping track of a cache locally.
This addresses a race condition when using the mounts structure.
Fixes #731