Skip to content

Use requested devices for CSV CDI spec generation #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+3 −2
Merged

Use requested devices for CSV CDI spec generation #1464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/modifier/csv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ import (
// NewCSVModifier creates a modifier that applies modications to an OCI spec if required by the runtime wrapper.
// The modifications are defined by CSV MountSpecs.
func NewCSVModifier(logger logger.Interface, cfg *config.Config, container image.CUDA) (oci.SpecModifier, error) {
if devices := container.VisibleDevices(); len(devices) == 0 {
devices := container.VisibleDevices()
if len(devices) == 0 {
logger.Infof("No modification required; no devices requested")
return nil, nil
}
Expand Down Expand Up @@ -63,7 +64,7 @@ func NewCSVModifier(logger logger.Interface, cfg *config.Config, container image
return nil, fmt.Errorf("failed to construct CDI library: %v", err)
}

spec, err := cdilib.GetSpec()
spec, err := cdilib.GetSpec(devices...)
if err != nil {
return nil, fmt.Errorf("failed to get CDI spec: %v", err)
}
Expand Down