Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Nov 12, 2025

🤖 Automated backport of #1410 to release-1.18

⚠️ This PR had merge conflicts that were resolved manually.

Original PR: #1410
Original Author: @elezar

Cherry-picked commits (1):

  • 4a4e7f8 Switch to go 1.25 os.Root

@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 12, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: Evan Lezar <[email protected]>
(cherry picked from commit 4a4e7f8)
@elezar elezar marked this pull request as ready for review November 12, 2025 22:01
@elezar elezar force-pushed the backport-1410-to-release-1.18 branch from 83154a7 to 5a76059 Compare November 12, 2025 22:02
@elezar elezar requested a review from cdesiniotis November 13, 2025 10:22
@ArangoGutierrez
Copy link
Collaborator

/ok to test 5a76059

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19360616114

Details

  • 0 of 31 (0.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 37.798%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/nvidia-cdi-hook/disable-device-node-modification/params_linux.go 0 6 0.0%
cmd/nvidia-cdi-hook/disable-device-node-modification/disable-device-node-modification.go 0 7 0.0%
internal/ldconfig/ldconfig.go 0 9 0.0%
internal/ldconfig/ldconfig_linux.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
internal/ldconfig/ldconfig_linux.go 1 0.0%
Totals Coverage Status
Change from base Build 19311796831: 0.1%
Covered Lines: 5136
Relevant Lines: 13588

💛 - Coveralls

Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport

@elezar elezar merged commit b7a9265 into release-1.18 Nov 14, 2025
13 checks passed
@elezar elezar deleted the backport-1410-to-release-1.18 branch November 14, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants