Fix ldcache update when host and container distributions do not match #1444
+102
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cherry-pick release-1.18 |
This was referenced Nov 11, 2025
elezar
force-pushed
the
fix-ldcache-update-on-non-debian
branch
2 times, most recently
from
9a32323 to
fb95f58
Compare
elezar
force-pushed
the
fix-ldcache-update-on-non-debian
branch
3 times, most recently
from
aa0c6fa to
a854d3d
Compare
cdesiniotis
approved these changes
Nov 14, 2025
Contributor
cdesiniotis
left a comment
cdesiniotis
left a comment
There was a problem hiding this comment.
I left a couple of comments / questions, but no blockers.
elezar
force-pushed
the
fix-ldcache-update-on-non-debian
branch
2 times, most recently
from
2794eaa to
0b28791
Compare
jfroy
reviewed
Nov 14, 2025
internal/ldconfig/ldconfig.go
Outdated
| func (l *Ldconfig) getSystemSerachPaths() []string { | ||
| func (l *Ldconfig) getSystemSearchPaths() []string { | ||
| if l.isDebianLikeContainer { | ||
| debianSystemSearchPaths() |
Collaborator
There was a problem hiding this comment.
I've been debugging issues on my homelab cluster with the latest CTK release, and I just spotted this code here. I think it's missing a return. I can send a PR for the existing code, or we can roll that fix into this PR.
Member
Author
There was a problem hiding this comment.
Thanks for the fix. In order to minimize backport churn, let's add the commit to this PR.
This was referenced Nov 15, 2025
elezar
force-pushed
the
fix-ldcache-update-on-non-debian
branch
from
f432507 to
70cca03
Compare
ArangoGutierrez
approved these changes
Nov 17, 2025
Collaborator
|
I'm preparing a follow up / alternative to this patch to handle additional cases I've ran into recently. Should have it out as a branch in an hour or so. |
cdesiniotis
approved these changes
Nov 18, 2025
elezar
force-pushed
the
fix-ldcache-update-on-non-debian
branch
2 times, most recently
from
7f73f39 to
22d7b5d
Compare
elezar
changed the title
This change ensures that updating the ldcache in a container also includes the system search paths for the container ldconfig. In most cases, the hook will be executing a host ldconfig that may be configured widely differently from what the container image expects. The common case is Debian vs non-Debian. But there are also hosts that configure ldconfig to search in a glibc prefix (e.g. /usr/lib/glibc). To avoid all these cases, write the container's expected system search paths to a drop-in conf file that is likely to be last in lexicographic order. Entries in the top-level ld.so.conf file may be processed after this drop-in, but this hook does not modify the top-level file if it exists. Signed-off-by: Jean-Francois Roy <[email protected]> Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
fix-ldcache-update-on-non-debian
branch
from
22d7b5d to
d3dcb86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the update of the ldcache when running a non-debian (including ubuntu) container on a debian-like system. Here the ldcache in the container does not initially include system libraries from
/lib64or/usr/lib64since thisldconfigfrom the host that is executed in the container's namespace does not process those paths by default.This is related to #1403 and will need to be updated once that is merged since we would also need to NOT include
lib64and/usr/lib64in the list of folders if it's already present in the config folders for some reason.Testing
The expected behaviour when using
runcdirectly:The current behaviour:
(note that
libc.so.6is not present in the ldcache since/lib64(linked to/usr/lib64) is not processed).The updated behaviour: