Skip to content

Conversation

@elezar
Copy link
Member

@elezar elezar commented Oct 23, 2025

This change fixes the handling of existing imports in containerd config files. Without this fix the existing imports were dropped and replaced with the import directive for the generated drop-in file.

Before this change:

$ cat test-config.toml
imports = ["/foo/bar/*.toml"]
version = 2

Run:

nvidia-ctk runtime configure --runtime=containerd --config=test-config.toml --drop-in-config=$(pwd)/99-nvidia.toml
$  cat test-config.toml
imports = ["/Users/elezar/dev/container-toolkit/*.toml"]
version = 2

With this change:

$ cat test-config.toml
imports = ["/foo/bar/*.toml", "/Users/elezar/dev/container-toolkit/*.toml"]
version = 2

This change fixes the handling of existing imports in containerd
config files. Without this fix the existing imports were dropped
and replaced with the import directive for the generated drop-in
file.

Signed-off-by: Evan Lezar <[email protected]>
@elezar
Copy link
Member Author

elezar commented Oct 23, 2025

/cherry-pick release-1.18

@tariq1890
Copy link
Contributor

LGTM. Thanks @elezar !

@elezar elezar merged commit 8188b55 into NVIDIA:main Oct 23, 2025
13 checks passed
@github-actions
Copy link

🤖 Backport PR created for release-1.18: #1384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants