Make list of explicit driver libraries opt-in #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
optional-explicit-libraries
branch
from
f6d8e9d to
16c8fcc
Compare
Instead of always injecting the list of explict libraries, we switch these to opt-in instead. This means that they can be generated in use cases such as GKE where they are expected, but don't affect other use cases where they are not. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
optional-explicit-libraries
branch
from
16c8fcc to
5a3dcbe
Compare
jgehrcke
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always injecting the list of explict libraries, we switch these to opt-in instead. This means that they can be generated in use cases such as GKE where they are expected, but don't affect other use cases where they are not.
See:
Note that this means that the DRA driver must set the feature flag when instantiating the
nvcdilibrary.