Skip to content

Add drop-in file support for containerd and crio #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
Merged

Add drop-in file support for containerd and crio #1280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0e0848
[no-relnote] Rename path member to topLevelConfigPath for clarity
elezar Sep 19, 2025
abcba21
Add drop-in file support for containerd and crio
elezar Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cmd/nvidia-ctk-installer/container/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ const (

// Options defines the shared options for the CLIs to configure containers runtimes.
type Options struct {
DropInConfig string
// TODO: Rename to TopLevelConfig
Config string
Socket string
// ExecutablePath specifies the path to the container runtime executable.
Expand Down Expand Up @@ -71,8 +73,12 @@ func (o Options) Unconfigure(cfg engine.Interface) error {

// flush flushes the specified config to disk
func (o Options) flush(cfg engine.Interface) error {
logrus.Infof("Flushing config to %v", o.Config)
n, err := cfg.Save(o.Config)
filepath := o.DropInConfig
if filepath == "" {
filepath = o.Config
}
logrus.Infof("Flushing config to %v", filepath)
n, err := cfg.Save(filepath)
if err != nil {
return fmt.Errorf("unable to flush config: %v", err)
}
Expand Down
Loading
Loading