Don't inject enable-cuda-compat hook in CSV mode #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the nvidia runtime in csv mode, we should not inject the enable-cuda-compat hook until we make the host driver version detection more robust on these platforms. As it is, the host driver version detection returns a version of 1.1 (the suffix of libcuda.so) meaning that CUDA forward compatibility will always be used in a container regardless of whether this is required. This will be properly added to the generated CDI spec for CSV-based platforms as a follow-up. Signed-off-by: Evan Lezar <[email protected]>
Member
Author
|
cc @agirault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the nvidia runtime in csv mode, we should not inject the enable-cuda-compat hook until we make the host driver version detection more robust on these platforms. As it is, the host driver version detection returns a version of 1.1 (the suffix of libcuda.so) meaning that CUDA forward compatibility will always be used in a container regardless of whether this is required.
This will be properly added to the generated CDI spec for CSV-based platforms as a follow-up. See #1271
This is a backport of #1270