Remove redundant CDI annotations #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17327741758Details
💛 - Coveralls |
When generating CDI specs for coherent and noncoherent devices, we include CDI device annotations. This increases the minimum CDI spec version to v0.6.0 which is not as widely supported as v0.5.0 or v0.3.0. This change removes these annotations after splitting the generated specs to produce coherent and/or non-coherent specs. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
remove-unneeded-cdi-annotations
branch
from
b7a508a to
afd934b
Compare
ArangoGutierrez
requested review from
ArangoGutierrez
and removed request for
ArangoGutierrez
ArangoGutierrez
approved these changes
Sep 8, 2025
Collaborator
ArangoGutierrez
left a comment
ArangoGutierrez
left a comment
There was a problem hiding this comment.
LGTM, thanks for the reply on my suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating CDI specs for coherent and noncoherent devices, we include CDI device annotations. This increases the minimum CDI spec version to v0.6.0 which is not as widely supported as v0.5.0 or v0.3.0.
This change removes these annotations after splitting the generated specs to produce coherent and/or non-coherent specs.
Closes #1262
Note that since we're generating a CDI spec for
nvidia.com/gpu.coherentdevices, these arev0.6.0specs since.was only allowed in the spec fromv0.6.0.