[no-relnote] Auto-regenerate CDI spec on toolkit changes #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monitor /usr/bin/nvidia-ctk for changes and trigger CDI refresh during package installation to ensure CDI specifications stay current with both driver and toolkit updates. - Add nvidia-ctk binary monitoring to systemd path unit - Trigger CDI refresh in DEB/RPM post-install scripts - Reorganize RPM spec to handle base package services correctly Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CDI (Container Device Interface) refresh mechanism to trigger updates when both NVIDIA drivers and the container toolkit are modified, ensuring CDI specifications remain synchronized across all components.
- Add monitoring of
/usr/bin/nvidia-ctkbinary changes to the systemd path unit - Implement immediate CDI refresh triggers in package post-install scripts for both DEB and RPM
- Reorganize RPM spec file to move systemd service management from main package to base package
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packaging/rpm/SPECS/nvidia-container-toolkit.spec | Moves systemd service setup and CDI refresh logic from main to base package |
| packaging/debian/nvidia-container-toolkit-base.postinst | Adds immediate CDI refresh trigger after package installation |
| deployments/systemd/nvidia-cdi-refresh.path | Extends monitoring to include nvidia-ctk binary changes |
Comments suppressed due to low confidence (1)
Pull Request Test Coverage Report for Build 16802195441Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitor /usr/bin/nvidia-ctk for changes and trigger CDI refresh during package installation to ensure CDI specifications stay current with both driver and toolkit updates.