Skip to content

Conversation

@ArangoGutierrez
Copy link
Collaborator

No description provided.

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez ArangoGutierrez self-assigned this Jul 17, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Holodeck dependency from version v0.2.12 to v0.2.13, including configuration adjustments to support the new version.

  • Updates Holodeck GitHub Action version reference in the e2e workflow
  • Removes hardcoded AMI image ID from AWS infrastructure configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/e2e.yaml Updates Holodeck action version from v0.2.12 to v0.2.13
tests/e2e/infra/aws.yaml Removes hardcoded AMI image ID configuration

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16349631434

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.012%

Totals Coverage Status
Change from base Build 16219798607: 0.0%
Covered Lines: 4442
Relevant Lines: 12687

💛 - Coveralls

@ArangoGutierrez
Copy link
Collaborator Author

Closing in favor of #1198

@elezar elezar reopened this Jul 21, 2025
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this so that we can show that #1194 fixes this issue.

@elezar elezar merged commit ac49ea2 into NVIDIA:main Jul 21, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants