Reenable nvsandboxutils for driver discovery #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
requested changes
May 22, 2025
This change reenables nvsandboxutils for driver discovery. This was disabled due to an error in a specific driver version (v565) so as to not block the release of the DRA driver for ComputeDomains. Signed-off-by: Evan Lezar <[email protected]>
This change adds support for feature flags to the nvcdi API. A feature flag to disable nvsandboxutils is also added to allow more flexibility in cases where this library causes issue. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
reenable-nvsandboxutils
branch
from
fc2d446 to
7bd65da
Compare
ArangoGutierrez
approved these changes
May 22, 2025
| } | ||
| l.nvmllib = nvml.New(nvmlOpts...) | ||
| } | ||
| // TODO: Repeated calls to nvsandboxutils.Init and Shutdown are causing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reenables nvsandboxutils for driver discovery. This was disabled due to an error in a specific driver version (v565) so as to not block the release of the DRA driver for ComputeDomains. See #935
A feature flag to disable nvsandboxutils is also added to allow more flexibility in cases where this library causes issue.