-
Notifications
You must be signed in to change notification settings - Fork 51
Add reconfigure api #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elezar
wants to merge
7
commits into
NVIDIA:main
Choose a base branch
from
elezar:add-reconfigure-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add reconfigure api #218
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5ea34a6
Add MIG Reconfigure API for vgpu-device-manager
elezar 89e8bfc
Return formatted errors instead of logging
elezar d4ed26a
Add commandRunnner interface and a basic test
elezar f793f1a
Update vendoring
elezar 6544a19
Add migParted interface for testing
elezar 36f8eef
Add nodeLabeller interface for testing
elezar 9cf3052
Add additional test cases
elezar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| package reconfigure | ||
|
|
||
| import "os/exec" | ||
|
|
||
| const ( | ||
| MIGConfigStateLabel = "nvidia.com/mig.config.state" | ||
| VGPUConfigStateLabel = "nvidia.com/vgpu.config.state" | ||
| ) | ||
|
|
||
| // A Reconfigurer applies a specified MIG configuration. | ||
| type Reconfigurer interface { | ||
| Reconfigure() error | ||
| } | ||
|
|
||
| // A commandRunner is used to run a constructed command. | ||
| // This interface allows us to inject a runner for testing. | ||
| // | ||
| //go:generate moq -rm -fmt=goimports -out command-runner_mock.go . commandRunner | ||
| type commandRunner interface { | ||
| Run(*exec.Cmd) error | ||
| } | ||
|
|
||
| // migParted defines an interface for interacting with mig-parted. | ||
| // | ||
| //go:generate moq -rm -fmt=goimports -out mig-parted_mock.go . migParted | ||
| type migParted interface { | ||
| assertValidMIGConfig() error | ||
| assertMIGConfig() error | ||
| assertMIGModeOnly() error | ||
| applyMIGModeOnly() error | ||
| applyMIGConfig() error | ||
| } | ||
|
|
||
| // nodeLabeller defines an interface for interacting with node labels. | ||
| // | ||
| //go:generate moq -rm -fmt=goimports -out node-labeller_mock.go . nodeLabeller | ||
| type nodeLabeller interface { | ||
| getNodeLabelValue(string) (string, error) | ||
| setNodeLabelValue(string, string) error | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: License header