Skip to content

Add support for building ubuntu22.04 on amd64 #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for building ubuntu22.04 on amd64 #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mk/docker.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ REVISION ?= $(shell git rev-parse HEAD)
include $(CURDIR)/versions.mk

# Supported OSs by architecture
AMD64_TARGETS := ubuntu20.04 ubuntu18.04 ubuntu16.04 debian10 debian9
AMD64_TARGETS := ubuntu22.04 ubuntu20.04 ubuntu18.04 ubuntu16.04 debian10 debian9
Copy link
Member

@elezar elezar Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as on NVIDIA/nvidia-container-toolkit#1004

Do we want to add arm64 builds here too?

Copy link
Author

@dschervov dschervov Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am apologize @elezar for long wait... All this time i try to find the ARM machine but without a success((( It will be an honor to me if you merge my request as it is, because i cant for 100% (like in this PR NVIDIA/nvidia-container-toolkit#1004 where i test on actuall ARM machine corretness) say that it will work on arm...

Yes, it will almost work good! What can stop the build it from correct execution? Its just a change of architecture... But i respect you, so i cant spoil my PR with lies...

X86_64_TARGETS := centos7 centos8 rhel7 rhel8 amazonlinux2 opensuse-leap15.1
PPC64LE_TARGETS := ubuntu18.04 ubuntu16.04 centos7 centos8 rhel7 rhel8
ARM64_TARGETS := ubuntu18.04
Expand Down Expand Up @@ -125,6 +125,10 @@ docker-amd64-verify: $(patsubst %, %-verify, $(AMD64_TARGETS)) \
--debian%: OS := debian
--amazonlinux%: OS := amazonlinux

# private ubuntu target with overrides
--ubuntu22.04%: WITH_TIRPC = yes
--ubuntu22.04%: WITH_LIBELF = yes

# private centos target with overrides
--centos%: OS := centos
--centos%: WITH_TIRPC = yes
Expand Down