Add IA32 and Display support

[xhejtman]

Moving my original PR from gitlab here.

This PR injects i386 libs that are neede by e.g., The Witcher 2 game, and injects Xorg modules nvidia_drv.so and libglxserver_nvidia.so that are needed for running Xserver in container.

Additional patch to the driver image is needed as well, will send another PR to the different repo.

The container with Xserver needs to copy or symlink the nvidia_drv.so and libglxserver_nvidia.so files. The nvidia_drv.so is renamed to libnvidia_drv.so so that standard injection mechanisms can be used. If there is a better way, let me know.

Of course, it would be far better to inject these two files directly to /usr/lib/xorg/driver and /usr/lib/xorg/modules, but I do not know, how to currently do it.

[elezar]

@xhejtman would making these changes to the NVIDIA Container Runtime in https://github.com/NVIDIA/nvidia-container-toolkit be an option instead?

[xhejtman]

@xhejtman would making these changes to the NVIDIA Container Runtime in https://github.com/NVIDIA/nvidia-container-toolkit be an option instead?

what do you mean here? the display part is depending on requested display capability. Do you want ia32 libs to be depending on some ia32 capability? Or something completely different?

[elezar]

The NVIDIA Container Runtime already includes functionality to discover and inject graphics libraries that are not covered by libnvidia-container: https://github.com/NVIDIA/nvidia-container-toolkit/blob/14ecacf6d1b21e07ece583d4fc432f393919f505/internal/discover/graphics.go#L273-L286

Going forward, we are moving away from using libnvidia-container to do injection and moving to CDI to define what is required. Making the change in the NVIDIA Container Runtime (especially handling 32-bit libs) whould allow that to be used too.

[xhejtman]

Ah, so using the Xserver in container should be already possible? Or is this for upcomming release? Is it anywere in documentation?

Btw, I think also driver needs to be changed so that Xorg libs are included in /run/nvidia/driver. Is this already done?

[elezar]

Ah, so using the Xserver in container should be already possible? Or is this for upcomming release? Is it anywere in documentation?

Most of the functionality should already be there, but our documentation is a little lacking at present. We are looking at updating this once we have sorted out some rough edges.

Btw, I think also driver needs to be changed so that Xorg libs are included in /run/nvidia/driver. Is this already done?

Yes, this is a known limitation. We are working with internal teams that also require this and will look at the impact of making these changes available as an opt-in feature at some point. Unfortunately I can't comment on the timeline at this point.

[xhejtman]

Ah, so using the Xserver in container should be already possible? Or is this for upcomming release? Is it anywere in documentation?

Most of the functionality should already be there, but our documentation is a little lacking at present. We are looking at updating this once we have sorted out some rough edges.

so for Xserver, this PR is basically obsolete, right?

Btw, I think also driver needs to be changed so that Xorg libs are included in /run/nvidia/driver. Is this already done?

Yes, this is a known limitation. We are working with internal teams that also require this and will look at the impact of making these changes available as an opt-in feature at some point. Unfortunately I can't comment on the timeline at this point.

so this part is on your own? No need to create PR for this?

[github-actions]

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label.

[xhejtman]

Hello, is there anything new here? Are you getting closer to support Display and IA32 libs?