Skip to content

Fix bug in ComputeDomain object being written to mutation cache #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgehrcke merged 1 commit into from
Nov 20, 2025
Merged

Fix bug in ComputeDomain object being written to mutation cache #721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/compute-domain-daemon/computedomain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,8 @@ func (m *ComputeDomainManager) removeNodeFromComputeDomain(ctx context.Context)
// Update status and (upon success) store the latest version of the object
// (as returned by the API server) in the mutation cache.
newCD.Status.Nodes = updatedNodes
if _, err := m.config.clientsets.Nvidia.ResourceV1beta1().ComputeDomains(newCD.Namespace).UpdateStatus(ctx, newCD, metav1.UpdateOptions{}); err != nil {
newCD, err = m.config.clientsets.Nvidia.ResourceV1beta1().ComputeDomains(newCD.Namespace).UpdateStatus(ctx, newCD, metav1.UpdateOptions{})
if err != nil {
Copy link
Collaborator

@jgehrcke jgehrcke Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connecting dots: we noticed this before; that's the only unresolved comment on #651:

#651 (comment)

return fmt.Errorf("error removing node from ComputeDomain status: %w", err)
}
m.mutationCache.Mutation(newCD)
Expand Down