Logging improvements for debuggability (CD daemon, plugin) #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Backlog
in Planning Board: k8s-dra-driver-gpu
Log claim name on prep for debuggability
Standard format is for example used in unprepare:
unprepared devices for claim \
'default/nvbandwidth-test-2-worker-0-compute-domain-channel-mnkrw:67417068-92da-4bbd-803c-ddcbbf0f067f'
In prepare, we so far only log by claim UID:
prepared devices for claim '67417068-92da-4bbd-803c-ddcbbf0f067f': ...
That makes things harder to debug (grepping plugin logs for
claim name should work).
Also, improve progress report on regular shutdown of the CD daemon.
Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>
jgehrcke
force-pushed
the
jp/misc-logging-improvements
branch
from
56c00ff to
0207dab
Compare
jgehrcke
commented
Oct 7, 2025
| if err != nil { | ||
| res := kubeletplugin.PrepareResult{ | ||
| Err: fmt.Errorf("error preparing devices for claim %v: %w", claim.UID, err), | ||
| Err: fmt.Errorf("error preparing devices for claim %s/%s:%s: %w", claim.Namespace, claim.Name, claim.UID, err), |
Collaborator
Author
There was a problem hiding this comment.
Maybe we can have a convenience method for this normalized string representation, just like we have for claimref.
klueska
approved these changes
Oct 7, 2025
klueska
added
the
debuggability
github-project-automation
bot
moved this from Backlog
to Closed
in Planning Board: k8s-dra-driver-gpu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small-ish but valuable log message improvements that I desired while investigating things over the last few days.
About (1): occasionally, I wondered if the global wait group's
wg.Wait()actually did return, and if it didn't -- which of the tasks in it would not have finished yet.About (2): that standard format is for example already used in unprepare:
In prepare, we so far only log by claim UID:
That makes things harder to debug (grepping plugin logs for the claim name should work).