Skip to content

Conversation

@jgehrcke
Copy link
Collaborator

@jgehrcke jgehrcke commented Mar 26, 2025

I don't quite understand this, but with the recent patch #298 in the output we see:

$ kubectl logs -n nvidia-dra-driver-gpu   repro2-compute-domain-x6dpf-m6z2l
-e /etc/nvidia-imex/nodes_config.cfg:


10.115.131.12

The fact that "-e" appears in the output is surprising. This should be a command line argument to echo. On my machine:

$ echo -e "test \n\n"
test 


Is that a different echo?

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ArangoGutierrez ArangoGutierrez requested a review from Copilot March 26, 2025 15:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix the output format for the nodes configuration in the IMEX daemon template by removing the unintended echo behavior caused by the "-e" flag.

  • Removed the "-e" flag from the echo command to prevent it from being printed in the logs
  • Separated the header echo and the file content cat commands for improved clarity
Comments suppressed due to low confidence (1)

templates/compute-domain-daemon.tmpl.yaml:40

  • [nitpick] Removing the -e flag prevents escape sequence interpretation. If the original formatting (i.e., additional newlines) was needed for clarity in the log output, consider explicitly adding the necessary newlines.
echo "/etc/nvidia-imex/nodes_config.cfg:"

@jgehrcke
Copy link
Collaborator Author

Yes. Different echo.

https://stackoverflow.com/a/46475616

echo -e is a nonstandard bash extension. Not only is it not required by the standard, it's not even allowed by the standard, which explicitly states that "Implementations shall not support any options".

@ArangoGutierrez ArangoGutierrez self-requested a review March 26, 2025 15:57
@jgehrcke jgehrcke merged commit f7fc619 into NVIDIA:main Mar 26, 2025
7 checks passed
fi
# Emit nodes config for facilitating debug.
echo -e "/etc/nvidia-imex/nodes_config.cfg:\n\n" && cat /etc/nvidia-imex/nodes_config.cfg
echo "/etc/nvidia-imex/nodes_config.cfg:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgehrcke whats the output after this change? Does it have a new line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

4 participants