Skip to content

versions.mk: change REGISTRY, add comment #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

versions.mk: change REGISTRY, add comment #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3693460
versions.mk: change REGISTRY, add comment
jgehrcke Mar 12, 2025
052744e
Rename: build-dra-driver.sh -> build-dra-driver-gpu.sh
jgehrcke Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ set -e

export VERSION=v25.2.0

REGISTRY=nvcr.io/nvidia/cloud-native
REGISTRY=nvcr.io/nvidia
IMAGE=k8s-dra-driver-gpu
PLATFORM=ubi9

Expand Down
0 demo/clusters/kind/build-dra-driver.sh → demo/clusters/kind/build-dra-driver-gpu.sh
View file
Open in desktop
File renamed without changes.
6 changes: 5 additions & 1 deletion versions.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,15 @@ DRIVER_NAME := k8s-dra-driver-gpu
HELM_DRIVER_NAME := nvidia-dra-driver-gpu
MODULE := github.com/NVIDIA/$(DRIVER_NAME)

REGISTRY ?= nvcr.io/nvidia/cloud-native
Copy link
Member

@elezar elezar Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: do the demo scripts depend on this?

Copy link
Collaborator Author

@jgehrcke jgehrcke Mar 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. REGISTRY is used in IMAGE_NAME which is scattered throughout Makefile targets.

I did veeery basic validation as part of this patch:

Did grep -nR cloud-native to see if there are other, obvious places that need changing. Answer is no.

Ran ./demo/clusters/kind/build-dra-driver-gpu.sh (renamed in this PR) and it worked. Part of its output was:

...
 => => writing image sha256:25c33684877a5fdd5d360138e0080d03f281b55e6e43a09baa9b3bb8ebeec471                                                                       0.0s
 => => naming to nvcr.io/nvidia/k8s-dra-driver-gpu:v25.3.0-rc.1-ubi9                                                                                               0.0s
docker image inspect nvcr.io/nvidia/k8s-dra-driver-gpu:v25.3.0-rc.1-ubi9 > /dev/null || docker pull nvcr.io/nvidia/k8s-dra-driver-gpu:v25.3.0-rc.1-ubi9
docker tag nvcr.io/nvidia/k8s-dra-driver-gpu:v25.3.0-rc.1-ubi9 nvcr.io/nvidia/k8s-dra-driver-gpu:v25.3.0-rc.1
+ cd /home/jgehrcke/dev/k8s-dra-driver-gpu/demo/clusters/kind/scripts
...
++ : kindest/node:v1.32.0
+ kind load docker-image --name k8s-dra-driver-gpu-cluster nvcr.io/nvidia/k8s-dra-driver-gpu:v25.3.0-rc.1
Image: "nvcr.io/nvidia/k8s-dra-driver-gpu:v25.3.0-rc.1" with ID "sha256:25c33684877a5fdd5d360138e0080d03f281b55e6e43a09baa9b3bb8ebeec471" not yet present on node "k8s-dra-driver-gpu-cluster-worker", loading...
Image: "nvcr.io/nvidia/k8s-dra-driver-gpu:v25.3.0-rc.1" with ID "sha256:25c33684877a5fdd5d360138e0080d03f281b55e6e43a09baa9b3bb8ebeec471" not yet present on node "k8s-dra-driver-gpu-cluster-control-plane", loading...
+ set +x

which I think confirms that the image was built and then 'loaded' in the kind environment, using the new location / REGISTRY.

REGISTRY ?= nvcr.io/nvidia

VERSION ?= v25.3.0-rc.1

# vVERSION represents the version with a guaranteed v-prefix
# Note: this is probably not consumed in our build chain.
# `VERSION` above is expected to have a `v` prefix, which is
# then automatically stripped in places that must not have it
# (e.g., in context of Helm).
vVERSION := v$(VERSION:v%=%)

GOLANG_VERSION := $(shell ./hack/golang-version.sh)
Expand Down