Skip to content

Remove v prefix from appVersion #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Remove v prefix from appVersion #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deployments/helm/nvidia-dra-driver-gpu/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ version: 25.3.0-rc.1
# It is recommended to use it with quotes.

# Note(JP): this currently defines the default `tag` value in a k8s
# image specification, and therefore must currently be v-prefixed.
appVersion: "v25.3.0-rc.1"
# image specification. A "v" is prefixed in our template helpers to ensure consistency.
appVersion: "25.3.0-rc.1"
2 changes: 1 addition & 1 deletion deployments/helm/nvidia-dra-driver-gpu/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Selector labels
Full image name with tag
*/}}
{{- define "nvidia-dra-driver-gpu.fullimage" -}}
{{- $tag := printf "%s" .Chart.AppVersion }}
{{- $tag := printf "v%s" .Chart.AppVersion }}
Copy link
Collaborator

@jgehrcke jgehrcke Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we should add a code comment here, too, if the template language allows for that.

{{- .Values.image.repository -}}:{{- .Values.image.tag | default $tag -}}
{{- end }}

Expand Down
5 changes: 2 additions & 3 deletions hack/package-helm-charts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,11 @@ set -o pipefail
# if arg1 is set, it will be used as the version number
if [ -z "$1" ]; then
VERSION=$(awk -F= '/^VERSION/ { print $2 }' versions.mk | tr -d '[:space:]')
# Remove any v prefix, if exists.
VERSION="${VERSION#v}"
Copy link
Collaborator

@jgehrcke jgehrcke Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, all of this is a great example that (well-maintained) code comments easily can save a bunch of time overall.

else
VERSION=$1
fi
VERSION=${VERSION}
# Remove any v prefix, if exists.
Copy link
Collaborator

@jgehrcke jgehrcke Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But.. the code below is broken. :)

 VERSION="${VERSION#v}"

Copy link
Member Author

@elezar elezar Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Updated.

VERSION="${VERSION#v}"


# Note(JP): the goal below is for VERSION to always be
Expand Down
Loading